Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait until logs appear right in e2e test #459

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Wait until logs appear right in e2e test #459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions test/frontend-integration-test/helloworld.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,10 @@ describe('deploy helloworld sample run', () => {
it('shows logs from node', () => {
$('button=Logs').click();
$('#logViewer').waitForVisible();
const logs = $('#logViewer').getText();
assert(logs.indexOf(outputParameterValue + ' from node: ') > -1,
'logs do not look right: ' + logs);
browser.waitUntil(() => {
const logs = $('#logViewer').getText();
return logs.indexOf(outputParameterValue + ' from node: ') > -1;
}, waitTimeout);
});
//TODO: enable this after we change the pipeline to a unique name such that deleting this
// pipeline will not jeopardize the concurrent basic e2e tests.
Expand Down