Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release): cherry pick #3 to 1.0.1 release #4467

Merged
merged 1 commit into from
Sep 4, 2020
Merged

chore(release): cherry pick #3 to 1.0.1 release #4467

merged 1 commit into from
Sep 4, 2020

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Sep 4, 2020

Part of #4361

@Ark-kun @Bobgy
refactor(components): De-hardcoded local output paths. (kubeflow#580)
4c9a8c0 
* Components - De-hardcoded local output paths.

* pip install pathlib2

* Added component.yaml changes

* The Dataflow components have been deleted
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.

Powered by ReviewNB

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign bobgy
You can assign the PR to them by writing /assign @bobgy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeflow-bot
Copy link

This change is Reviewable

@Bobgy Bobgy changed the base branch from master to release-1.0 September 4, 2020 07:51
@Bobgy
Copy link
Contributor Author

Bobgy commented Sep 4, 2020

/retest

@Bobgy
Copy link
Contributor Author

Bobgy commented Sep 4, 2020

/retest

@google-cla
Copy link

google-cla bot commented Sep 4, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Sep 4, 2020
@Bobgy
Copy link
Contributor Author

Bobgy commented Sep 4, 2020

/retest

@Bobgy Bobgy added the cla: yes label Sep 4, 2020
@google-cla google-cla bot removed the cla: no label Sep 4, 2020
@Bobgy Bobgy merged commit 09a020d into kubeflow:release-1.0 Sep 4, 2020
@Bobgy Bobgy deleted the cp_1.0.1-2 branch September 4, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaoning777 gaoning777 Awaiting requested review from gaoning777

@hougangliu hougangliu Awaiting requested review from hougangliu

Assignees
No one assigned
Labels
cla: yes size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Bobgy @k8s-ci-robot @kubeflow-bot @Ark-kun