Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): Backend - Cache - Fixed reinstallation. Fixes #4299 (#4320) #4382

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Aug 17, 2020

No description provided.

…4299 (kubeflow#4320)

* Backend - Cache - Fixed reinstallation by adding missing roles

* Stop ignoring the deletion errors

* Added patch permission as well

It should not be triggered, but might be useful in the future.
@kubeflow-bot
Copy link

This change is Reviewable

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 17, 2020

/retest

@Bobgy
Copy link
Contributor

Bobgy commented Aug 17, 2020

/lgtm
/approve
/hold

I will rebase merge cherry picks.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy Bobgy merged commit f5e9901 into kubeflow:release-1.0 Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants