Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend - Simplified sample compilation #399

Closed

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Nov 28, 2018

There is not need to install Java, run swagger codegen, build and install the package. The pipelines can be compiled without all that.


This change is Reviewable

@Ark-kun Ark-kun force-pushed the avolkov/Backend---Simplified-sample-compilation branch 2 times, most recently from a9232ff to ba2bfef Compare December 1, 2018 04:57
…ava, run swagger codegen, build and install the package. The pipelines can be compiled without all that.
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Dec 1, 2018

Depends on #210 which makes it so that the compilation does not depend on google.cloud.storage package.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Dec 3, 2018

/test build-image

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Dec 3, 2018

Now waiting for #442

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Dec 4, 2018

/test build-image

@Ark-kun Ark-kun changed the title [WIP] Backend - Simplified sample compilation Backend - Simplified sample compilation Dec 4, 2018
@Ark-kun Ark-kun requested a review from qimingj December 4, 2018 04:08
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Dec 4, 2018

/test presubmit-sample-test

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Dec 5, 2018

@qimingj
Copy link
Contributor

qimingj commented Dec 7, 2018

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Dec 8, 2018

/approve

1 similar comment
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Dec 8, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Ark-kun
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: qimingj

If they are not already assigned, you can assign the PR to them by writing /assign @qimingj in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Ark-kun
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: qimingj

If they are not already assigned, you can assign the PR to them by writing /assign @qimingj in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Dec 8, 2018

/retest

@vicaire
Copy link
Contributor

vicaire commented Apr 25, 2019

@Ark-kun, do you still need this one? Should it be closed?

@k8s-ci-robot
Copy link
Contributor

@Ark-kun: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
kubeflow-pipeline-build-image ba2bfef link /test kubeflow-pipeline-build-image
kubeflow-pipeline-sample-test ba2bfef link /test kubeflow-pipeline-sample-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 13, 2019

@Ark-kun Ark-kun closed this Aug 13, 2019
@IronPan IronPan deleted the avolkov/Backend---Simplified-sample-compilation branch August 27, 2019 21:09
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
HumairAK referenced this pull request in red-hat-data-services/data-science-pipelines Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants