-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend - Simplified sample compilation #399
Conversation
a9232ff
to
ba2bfef
Compare
…ava, run swagger codegen, build and install the package. The pipelines can be compiled without all that.
Depends on #210 which makes it so that the compilation does not depend on |
/test build-image |
Now waiting for #442 |
/test build-image |
/test presubmit-sample-test |
The sample tests finished successfully: https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/kubeflow_pipelines/399/presubmit-sample-test/557/ |
/lgtm |
/approve |
1 similar comment
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Ark-kun If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Ark-kun If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@Ark-kun, do you still need this one? Should it be closed? |
@Ark-kun: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There is not need to install Java, run swagger codegen, build and install the package. The pipelines can be compiled without all that.
This change is