Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move default gcp op to dsl/ #376

Merged
merged 1 commit into from
Nov 26, 2018
Merged

move default gcp op to dsl/ #376

merged 1 commit into from
Nov 26, 2018

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Nov 26, 2018

This change is Reviewable

@IronPan
Copy link
Member Author

IronPan commented Nov 26, 2018

/assign @qimingj

@qimingj
Copy link
Contributor

qimingj commented Nov 26, 2018

/lgtm

@IronPan
Copy link
Member Author

IronPan commented Nov 26, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@IronPan
Copy link
Member Author

IronPan commented Nov 26, 2018

/test build-image

@k8s-ci-robot k8s-ci-robot merged commit 6003a63 into master Nov 26, 2018
@IronPan IronPan deleted the yangpa/gop branch December 10, 2018 22:26
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants