Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clusterrolebinding is using namespace which not parametrized #3573

Merged
merged 2 commits into from
Apr 21, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,5 @@ roleRef:
subjects:
- kind: ServiceAccount
name: kubeflow-pipelines-cache-deployer-sa
# Here it should be changed or overwrite to well match with customized namespace
namespace: kubeflow
3 changes: 2 additions & 1 deletion manifests/kustomize/env/dev/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,6 @@ bases:
commonLabels:
application-crd-id: kubeflow-pipelines

# Replace with your namespace
# !!! If you want to customize the namespace,
# please also update base/cache-deployer/cluster-scoped/cache-deployer-clusterrolebinding.yaml
namespace: kubeflow
3 changes: 2 additions & 1 deletion manifests/kustomize/env/gcp/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ bases:
commonLabels:
application-crd-id: kubeflow-pipelines

# Replace with your namespace
# !!! If you want to customize the namespace,
# please also update base/cache-deployer/cluster-scoped/cache-deployer-clusterrolebinding.yaml
namespace: kubeflow

patchesStrategicMerge:
Expand Down
3 changes: 2 additions & 1 deletion manifests/kustomize/env/platform-agnostic/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ bases:
commonLabels:
application-crd-id: kubeflow-pipelines

# Replace with your namespace
# !!! If you want to customize the namespace,
# please also update base/cache-deployer/cluster-scoped/cache-deployer-clusterrolebinding.yaml
namespace: kubeflow

images:
Expand Down
2 changes: 1 addition & 1 deletion manifests/kustomize/sample/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ kubectl apply -k sample/
# If upper one action got failed, e.x. you used wrong value, try delete, fix and apply again
# kubectl delete -k sample/

kubectl wait applications/mypipeline -n mykubeflow --for condition=Ready --timeout=1800s
kubectl wait applications/mypipeline -n kubeflow --for condition=Ready --timeout=1800s
```

Now you can find the installation in [Console](http://console.cloud.google.com/ai-platform/pipelines)
Expand Down
12 changes: 7 additions & 5 deletions manifests/kustomize/sample/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,12 @@ secretGenerator:
env: params-db-secret.env
behavior: merge

# !!! If you want to customize the namespace,
# please also update base/cache-deployer/cluster-scoped/cache-deployer-clusterrolebinding.yaml
namespace: kubeflow

#### Customization ###
# 1. Replace with your namespace
namespace: mykubeflow
# 2. Change values in params.env file
# 3. Change values in params-db-secret.env file for CloudSQL username and password
# 4. kubectl apply -k ./
# 1. Change values in params.env file
# 2. Change values in params-db-secret.env file for CloudSQL username and password
# 3. kubectl apply -k ./
####