Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Make service account configurable for build_image_from_working_dir #3419

Merged
merged 13 commits into from
Apr 15, 2020
Prev Previous commit
Next Next commit
Update _build_image_api.py
Bobgy authored Apr 15, 2020
commit 9a47c010cbd3b6cc23b9b9a1250123d11dcf1d8f
3 changes: 2 additions & 1 deletion sdk/python/kfp/containers/_build_image_api.py
Original file line number Diff line number Diff line change
@@ -80,7 +80,8 @@ def build_image_from_working_dir(image_name: str = None, working_dir: str = None
timeout: Optional. The image building timeout in seconds.
base_image: Optional. The container image to use as the base for the new image. If not set, the Google Deep Learning Tensorflow CPU image will be used.
builder: Optional. An instance of ContainerBuilder or compatible class that will be used to build the image.
The default builder uses "kubeflow-pipelines-container-builder" service account in "kubeflow" namespace. It works with Kubeflow Pipelines clusters installed using Google Cloud Marketplace or Standalone with version > 0.4.0.
The default builder uses "kubeflow-pipelines-container-builder" service account in "kubeflow" namespace. It works with Kubeflow Pipelines clusters installed in "kubeflow" namespace using Google Cloud Marketplace or Standalone with version > 0.4.0.
If your Kubeflow Pipelines is installed in a different namespace, you should use ContainerBuilder(namespace='<your-kfp-namespace>', ...).
Depending on how you installed Kubeflow Pipelines, you need to configure your ContainerBuilder instance's namespace and service_account:
For clusters installed with Kubeflow >= 0.7, use ContainerBuidler(namespace='<your-user-namespace>', service_account='default-editor', ...). You can omit the namespace if you use kfp sdk from in-cluster notebook, it uses notebook namespace by default.
For clusters installed with Kubeflow < 0.7, use ContainerBuilder(service_account='default', ...).