[Testing] Use full scope cluster for testing to reduce flakiness #3018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks @Bobgy ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
After switching to 1.14.8-gke.33 in https://github.com/kubeflow/pipelines/pull/2912/files. Tests have been super flaky. It's affecting daily development a lot. Each test takes forever to retry tests.
Proposal
But I think we don't need to test too much about workload identity now. Also, test coverage of KFP code is not in anyway different between workload identity and full scope cluster (because both are transparent layer to handle authentication to GCP).
Therefore, I think it would be the best if we switch presubmit tests to full scope. When there's a stable GKE version with workload identity support, we can switch back to workload identity or add workload identity as postsubmit test.
Verification
Let's retry a few times to verify if full scope cluster will indeed solve flakiness problem.
This change is