Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Frontend - Metadata - Switching to contexts #2852

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Jan 16, 2020

Fixes #2562


This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign bobgy
You can assign the PR to them by writing /assign @bobgy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun Ark-kun force-pushed the Frontend---Metadata---Switching-to-contexts branch from 6b4f494 to 5120883 Compare January 16, 2020 01:05
@Ark-kun Ark-kun removed the request for review from neuromage January 16, 2020 01:06
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jan 16, 2020

@Bobgy Do you know the best way to update the metadata protobuf generated files?

@Bobgy
Copy link
Contributor

Bobgy commented Jan 16, 2020

@Ark-kun Sorry I didn't get enough time to pick up this. Thanks for jumping in by yourself.

I only knew the proto lives https://github.com/google/ml-metadata/tree/master/ml_metadata/proto.
I think @neuromage should know more about how it was used to generate the apis.

@k8s-ci-robot
Copy link
Contributor

@Ark-kun: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-pipeline-frontend-test 5120883 link /test kubeflow-pipeline-frontend-test
kubeflow-pipeline-sample-test 5120883 link /test kubeflow-pipeline-sample-test
kubeflow-pipeline-e2e-test 5120883 link /test kubeflow-pipeline-e2e-test
kubeflow-pipeline-upgrade-test 5120883 link /test kubeflow-pipeline-upgrade-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stale
Copy link

stale bot commented Jun 24, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Jun 24, 2020
@stale
Copy link

stale bot commented Jul 1, 2020

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@stale stale bot closed this Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend do-not-merge/work-in-progress lifecycle/stale The issue / pull request is stale, any activities remove this label. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metadata UX - Artifacts and Executions should be grouped based on Metadata Context
3 participants