Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store DB password as K8s secret for marketplace deployment #2067

Merged
merged 16 commits into from
Sep 10, 2019

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Sep 9, 2019

/assign @rmgogogo


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added size/S and removed size/M labels Sep 9, 2019
@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Sep 9, 2019
@IronPan
Copy link
Member Author

IronPan commented Sep 10, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rmgogogo
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 715471f into kubeflow:master Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants