Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change schema.yaml to v2 #2009

Merged
merged 8 commits into from
Sep 3, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions manifests/gcp_marketplace/chart/kubeflow-pipelines/values.yaml
Original file line number Diff line number Diff line change
@@ -1,33 +1,33 @@
images:
mysql: gcr.io/ml-pipeline/mysql:5.6
apiServer: gcr.io/ml-pipeline/api-server:0.1.27
argoExecutor: gcr.io/ml-pipeline/argoexec:v2.3.0
argoWorkflowController: gcr.io/ml-pipeline/workflow-controller:v2.3.0
cloudsqlProxy: gcr.io/cloudsql-docker/gce-proxy:1.14
frontend: gcr.io/ml-pipeline/frontend:0.1.27
metadataServer: gcr.io/kubeflow-images-public/metadata:v0.1.8
minio: gcr.io/ml-pipeline/minio:RELEASE.2019-08-14T20-37-41Z
apiServer: gcr.io/ml-pipeline/api-server:0.1.27
mysql: gcr.io/ml-pipeline/mysql:5.6
persistenceagent: gcr.io/ml-pipeline/persistenceagent:0.1.27
proxyAgent: gcr.io/ml-pipeline/inverse-proxy-agent:0.1.27
scheduledworkflow: gcr.io/ml-pipeline/scheduledworkflow:0.1.27
frontend: gcr.io/ml-pipeline/frontend:0.1.27
viewerCrd: gcr.io/ml-pipeline/viewer-crd-controller:0.1.27
visualizationServer: gcr.io/ml-pipeline/visualization-server:0.1.27
metadataServer: gcr.io/kubeflow-images-public/metadata:v0.1.8
proxyAgent: gcr.io/ml-pipeline/inverse-proxy-agent:0.1.27
argoExecutor: gcr.io/ml-pipeline/argoexec:v2.3.0
argoWorkflowController: gcr.io/ml-pipeline/workflow-controller:v2.3.0

serviceAccount:
proxyAgentRunner: null
argo: null
mlPipeline: null
mlPipelinePersistenceAgent: null
mlPipelineScheduledWorkflow: null
mlPipelineUI: null
mlPipelineViewerCrd: null
mlPipeline: null
pipelineRunner: null
argo: null
proxyAgentRunner: null

managedstorage:
enabled: false
cloudsqlInstanceName: null
cloudsqlZone: null
databaseNamePrefix: null
dbPassword: null
enabled: false
gcpProject: null
gcpSecretName: null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sort

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

databaseNamePrefix: null
2 changes: 1 addition & 1 deletion manifests/gcp_marketplace/deployer/Dockerfile
Original file line number Diff line number Diff line change
@@ -1 +1 @@
FROM gcr.io/cloud-marketplace-tools/k8s/deployer_helm/onbuild
FROM gcr.io/ml-pipeline/marketplace-k8s-app-tools/k8s/deployer_helm/onbuild:0829-pr396
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's with this tag? is it temporary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes this is an unofficial image. the change is not in marketplace prod yet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i talked with marketplace and using this should be fine for now.

178 changes: 99 additions & 79 deletions manifests/gcp_marketplace/schema.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,82 @@
applicationApiVersion: v1beta1
x-google-marketplace:
schemaVersion: v2
applicationApiVersion: v1beta1
publishedVersion: '0.1.27'
publishedVersionMetadata:
releaseNote: >-
Initial release.
releaseTypes:
- Feature
recommended: false
managedUpdates:
kalmSupported: false
images:
'':
properties:
imageRepo:
type: REPO_WITH_REGISTRY
imageTag:
type: TAG
mysql:
properties:
images.mysql:
type: FULL
minio:
properties:
images.minio:
type: FULL
argoExecutor:
properties:
images.argoExecutor:
type: FULL
argoWorkflowController:
properties:
images.argoWorkflowController:
type: FULL
apiServer:
properties:
images.apiServer:
type: FULL
persistenceagent:
properties:
images.persistenceagent:
type: FULL
scheduledworkflow:
properties:
images.scheduledworkflow:
type: FULL
frontend:
properties:
images.frontend:
type: FULL
viewerCrd:
properties:
images.viewerCrd:
type: FULL
visualizationServer:
properties:
images.visualizationServer:
type: FULL
metadataServer:
properties:
images.metadataServer:
type: FULL
proxyAgent:
properties:
images.proxyAgent:
type: FULL
cloudsqlProxy:
properties:
images.cloudsqlProxy:
type: FULL
deployerServiceAccount:
roles:
- type: ClusterRole # This is a cluster-wide ClusterRole
rulesType: CUSTOM # We specify our own custom RBAC roles
rules:
- apiGroups: ['apiextensions.k8s.io']
resources: ['customresourcedefinitions']
verbs: ['*']

properties:
name:
Expand All @@ -9,71 +87,26 @@ properties:
type: string
x-google-marketplace:
type: NAMESPACE
# image.mysql:
# type: string
# default: $REGISTRY/mysql:5.6
# x-google-marketplace:
# type: IMAGE
# image.minio:
# type: string
# default: $REGISTRY/minio:RELEASE.2018-02-09T22-40-05Z
# x-google-marketplace:
# type: IMAGE
# image.argoExecutor:
# type: string
# default: $REGISTRY/argoexec:v2.3.0
# x-google-marketplace:
# type: IMAGE
# image.argoWorkflowController:
# type: string
# default: $REGISTRY/workflow-controller:v2.3.0
# x-google-marketplace:
# type: IMAGE
# image.apiServer:
# type: string
# default: $REGISTRY/api-server:$TAG
# x-google-marketplace:
# type: IMAGE
# image.persistenceagent:
# type: string
# default: $REGISTRY/persistenceagent:$TAG
# x-google-marketplace:
# type: IMAGE
# image.scheduledworkflow:
# type: string
# default: $REGISTRY/scheduledworkflow:$TAG
# x-google-marketplace:
# type: IMAGE
# image.frontend:
# type: string
# default: $REGISTRY/frontend:$TAG
# x-google-marketplace:
# type: IMAGE
# image.viewerCrd:
# type: string
# default: $REGISTRY/viewer-crd-controller:$TAG
# x-google-marketplace:
# type: IMAGE
# image.visualizationServer:
# type: string
# default: $REGISTRY/visualization-server:$TAG
# x-google-marketplace:
# type: IMAGE
# image.metadataServer:
# type: string
# default: gcr.io/kubeflow-images-public/metadata:v0.1.8
# x-google-marketplace:
# type: IMAGE
# image.proxyAgent:
# type: string
# default: $REGISTRY/inverse-proxy-agent:$TAG
# x-google-marketplace:
# type: IMAGE
# image.cloudsqlProxy:
# type: string
# default: gcr.io/cloudsql-docker/gce-proxy:1.14
# x-google-marketplace:
# type: IMAGE
managedstorage.enabled:
type: boolean
title: Enable managed storage
description: Use Cloud SQL and GCS for storing the data
default: false
managedstorage.cloudsqlInstanceName:
type: string
title: CloudSQL instance name
managedstorage.cloudsqlZone:
type: string
title: CloudSQL zone
managedstorage.dbPassword:
type: string
title: database password
managedstorage.gcpProject:
type: string
title: GCP project
managedstorage.databaseNamePrefix:
type: string
title: database name prefix
serviceAccount.proxyAgentRunner:
type: string
title: ProxyAgentRunnerServiceAccount
Expand Down Expand Up @@ -385,16 +418,3 @@ properties:
required:
- name
- namespace

x-google-marketplace:
deployerServiceAccount:
roles:
- type: ClusterRole # This is a cluster-wide ClusterRole
rulesType: CUSTOM # We specify our own custom RBAC roles
rules:
- apiGroups: ['apiextensions.k8s.io']
resources: ['customresourcedefinitions']
verbs: ['*']
- type: Role # This is a namespaced Role
rulesType: PREDEFINED
rulesFromRoleName: edit # Use predefined role named "edit"