Bug fix and add unit test for sample-test/utils.file_injection #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix a bug in file_injection.
|
/lgtm |
|
Thanks @Ark-kun |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: numerology The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7 tasks
|
thanks, /lgtm |
|
I have a little bit of concern about the file structure. Since many file/directory in the project_repo/test contains the word 'test', it will be confusing to have the unit test files for the test infra codes live in the same directory. Maybe we can create a separate directory called unit_tests, or something to separate the test infra codes from the unit test codes. WDYT? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current file_injection function cannot correctly process multi-pattern replacement. This is a fix to that.
Also added a unit-test to prevent that from happening again.
This change is