[WIP]Components - Release - Improved MacOS X compatibility #1780
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ark-kun
changed the title
|
@Ark-kun: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
lifecycle/stale
|
This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it. |
* Replace AWS_REGION with AWS_DEFAULT_REGION The boto3 package seems to look for AWS_DEFAULT_REGION, meanwhile kfserving uses AWS_REGION, that doesn't seem to be working (tested following https://github.com/kubeflow/kfserving/blob/master/docs/samples/storage/s3/README.md). This change doesn't replace all occurrences of AWS_REGION, but only the ones that set the environment variables. kubeflowGH-1765 * s3_secrets: support AWS_CA_BUNDLE This change adds the possibility to force boto to use a different CA bundle path when validating the TLS certificate of the S3 endpoint. Our use case is to validate a TLS certificate of an internal Openstack Swift/S3 endpoint signed by our internal CA. kubeflowGH-1766
This change is