-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SageMaker create workteam and Ground Truth components, sample demo pipeline, other minor updates #1716
Add SageMaker create workteam and Ground Truth components, sample demo pipeline, other minor updates #1716
Conversation
…d train, add sample pipeline demo for workteam and GT, update images
Hi @carolynwang. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @Jeffwan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 Add status check on every client.request value. Its missing and some time it might take wait for xyz to complete
function to realize.
over all LGTM
@@ -71,7 +71,7 @@ outputs: | |||
- {name: output_location, description: 'S3 URI of the transform job results.'} | |||
implementation: | |||
container: | |||
image: carowang/kubeflow-pipeline-aws-sm:20190728-01 | |||
image: carowang/kubeflow-pipeline-aws-sm:20190801-01 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this image is to somewhere in AWS official dockerhub ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes will do once I get more info on how to do so
|
||
auto_labeling_map = {'bounding box': 'object-detection', | ||
'image classification': 'image-classification', | ||
'text classification': 'text-classification'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if I want to stage a custom image labeling task? I don't see that case here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in terms of automatic data labeling for custom labeling jobs - Ground Truth currently doesn't support that, which is why this map only contains the built-in algos that have auto data labeling support
in general though, custom tasks are handled while updating pre-human and annotation consolidation task lambda functions
/lgtm |
/ok-to-test |
/hold |
@carolynwang Please move samples to https://github.com/kubeflow/pipelines/tree/master/samples/contrib/aws Original path was refactored and all vendors related are moved to |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jeffwan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
/lgtm |
Summary
@Jeffwan @mbaijal @gautamkmr @kalyc
Add create workteam and Ground Truth (data labeling) components
Update HPO and train components
Add a small image classification pipeline to demo workteam and GT components
Update Docker image used for components
Testing
Component functionality
This change is