Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unit test bug: python dict is not ordered. #1551

Closed
wants to merge 1 commit into from
Closed

fix unit test bug: python dict is not ordered. #1551

wants to merge 1 commit into from

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Jun 25, 2019

This change is Reviewable

@elikatsis
Copy link
Member

Quoting my comment on Alexey's (@Ark-kun) PR (#1553)

I'm not sure if this is a proper way to test it.

@derekhh has submitted a PR (#1554) which seems pretty good. WDYT?

@IronPan
Copy link
Member

IronPan commented Jun 25, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaoning777
Copy link
Contributor Author

Close in favor of #1554

@gaoning777 gaoning777 closed this Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants