Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep Experiments button in sidenav highlighted on non-pipeline pages #126

Closed
wants to merge 1 commit into from
Closed

Keep Experiments button in sidenav highlighted on non-pipeline pages #126

wants to merge 1 commit into from
+540 −71

Conversation

rileyjbauer
Copy link
Contributor

@rileyjbauer rileyjbauer commented Nov 7, 2018 •
edited by jlewi
Loading

Fixes: #71

Keeps Experiments button/tab on the side-nav highlighted for all non-pipeline pages, including RecurringRunDetails and Compare.

Changes the title on the AllRunsList page to match that of the ExperimentList page and adds Create new experiment button to AllRunsList

Note that we probably should truly merge these pages at some point.

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rileyjbauer

If they are not already assigned, you can assign the PR to them by writing /assign @rileyjbauer in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-prow-robot
Copy link
Collaborator

@rileyjbauer: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
mlpipeline-presubmit-e2e-test f11c3d8 link /test mlpipeline-presubmit-e2e-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rileyjbauer
Copy link
Contributor Author

Closed as duplicate of #124

@rileyjbauer rileyjbauer closed this Nov 7, 2018
@rileyjbauer rileyjbauer deleted the standardize-allruns-and-experimentlist-pages branch November 12, 2018 17:51
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@jlewi
Catch arbitrary exceptions in wait_for_workflows and log them so they (…
a88bad7 
…kubeflow#126)

show up in build-log.txt reported to Gubernator.

Related to kubeflow#125
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@gyliu513 @k8s-ci-robot
Enabled go lint. (kubeflow#126)
43eea34
HumairAK referenced this pull request in red-hat-data-services/data-science-pipelines Mar 11, 2024
@ckadner
Use make commands for test and report (#126)
406db99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronPan IronPan Awaiting requested review from IronPan

@yebrahim yebrahim Awaiting requested review from yebrahim

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rileyjbauer @k8s-ci-robot @google-prow-robot