Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to using gh container registry in manifests #11526

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

HumairAK
Copy link
Collaborator

@HumairAK HumairAK commented Jan 16, 2025

Description of your changes:

This change switches majority of the images coming from gcr repository to the ghcr repository. For this, various manifests were updated, as well as the hardcoded launcher/driver images. All images that are regularly updated during the release process have been switched over to ghcr.

Note: I will follow up with updates to release instructions once we are done with the 2.4 release.

Checklist:

This change switches majority of the images coming from gcr repository
to the ghcr repository. For this various manifests were updated, as well
as the hardcoded launcher/driver images. All images that are regularly
updated during the release process have been switched over to ghcr.

Signed-off-by: Humair Khan <[email protected]>
@HumairAK
Copy link
Collaborator Author

HumairAK commented Jan 16, 2025

There is a bit of a chicken and egg problem with the driver/launcher images. I built the images from the release-2.4.0 branch which has not gone out yet, but will do so once this change is cherry-picked into that branch, and the release workflow is initiated. But before that, the api server image will need to be rebuilt on the 2.4.0 tag so that the hardcoded launcher/driver images make it into the apiserver. This should be fine to do since we have officially released anything. But in the future it would be good to add these images via manifests (env vars) and update them part of the regular release process, as we do the other images in yaml. For default hardcoded values, we can just either not use defaults and throw an error, or point to latest.

@HumairAK
Copy link
Collaborator Author

Cc @chensun

@HumairAK HumairAK requested a review from chensun January 16, 2025 13:37
@rimolive
Copy link
Member

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 4517cbe into kubeflow:master Jan 16, 2025
37 checks passed
HumairAK added a commit to HumairAK/data-science-pipelines that referenced this pull request Jan 16, 2025
…1526)

This change switches majority of the images coming from gcr repository
to the ghcr repository. For this various manifests were updated, as well
as the hardcoded launcher/driver images. All images that are regularly
updated during the release process have been switched over to ghcr.

Signed-off-by: Humair Khan <[email protected]>
google-oss-prow bot pushed a commit that referenced this pull request Jan 16, 2025
…11527)

This change switches majority of the images coming from gcr repository
to the ghcr repository. For this various manifests were updated, as well
as the hardcoded launcher/driver images. All images that are regularly
updated during the release process have been switched over to ghcr.

Signed-off-by: Humair Khan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants