Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Fix the frontend image build with Node 22 #11524

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

mprahl
Copy link
Contributor

@mprahl mprahl commented Jan 15, 2025

Description of your changes:

This updates minio to be compatible with Node 22 and additionally updates the frontend server base image to use Node 22.

Checklist:

Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@mprahl
Copy link
Contributor Author

mprahl commented Jan 15, 2025

The frontend image build worked locally with this change:

pipelines on  fix-node:master [$?⇡] via 🐹 v1.22.0 via 🐍 v3.10.14 (pipelines) took 19s ❯ docker build -f frontend/Dockerfile -t kfp-frontend:temp .
[+] Building 39.8s (8/19)                                                                                                                                 docker:default
[+] Building 165.8s (11/19)                                                                                                                               docker:default
[+] Building 166.1s (11/19)                                                                                                                               docker:default
[+] Building 627.4s (20/20) FINISHED                                                                                                                      docker:default
 => [internal] load build definition from Dockerfile                                                                                                                0.0s
 => => transferring dockerfile: 933B                                                                                                                                0.0s
 => WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 1)                                                                                      0.0s
 => [internal] load metadata for docker.io/library/node:22.13-alpine                                                                                                0.2s
 => [internal] load metadata for docker.io/library/node:22.13                                                                                                       0.2sd
 => [internal] load .dockerignore                                                                                                                                   0.0s
 => => transferring context: 464B                                                                                                                                   0.0sd
 => [stage-1 1/6] FROM docker.io/library/node:22.13-alpine@sha256:f2dc6eea95f787e25f173ba9904c9d0647ab2506178c7b5b7c5a3d02bc4af145                                  8.4s
 => => resolve docker.io/library/node:22.13-alpine@sha256:f2dc6eea95f787e25f173ba9904c9d0647ab2506178c7b5b7c5a3d02bc4af145                                          0.0sd
 => => sha256:82c0e88b37bacc0006df84edd0b6aed34f11f5392078539f9999b0fb5d7a5939 50.25MB / 50.25MB                                                                    6.2s
 => => sha256:3f4550e9f92dc34790c242052e1ef3b2b5614baf200f1125063c16313a8f6a16 1.26MB / 1.26MB                                                                      0.8s
 => => sha256:f2dc6eea95f787e25f173ba9904c9d0647ab2506178c7b5b7c5a3d02bc4af145 6.41kB / 6.41kB                                                                      0.0s
 => => sha256:133cdce957f50f47236d6d926592fb1db7a120ac3c33191e611b60dfab63e324 1.72kB / 1.72kB                                                                      0.0s
 => => sha256:546c0b137912a891ce123d1495339ca4d4412c6856a7377f5ac39464da6f28c9 6.18kB / 6.18kB                                                                      0.0s
 => => sha256:1f3e46996e2966e4faa5846e56e76e3748b7315e2ded61476c24403d592134f0 3.64MB / 3.64MB                                                                      0.8s
 => => extracting sha256:1f3e46996e2966e4faa5846e56e76e3748b7315e2ded61476c24403d592134f0                                                                           0.2s
 => => sha256:a0178999f9f2ff9194a1cb98029ffff25c527d8872d0f91fe1b38e0fdf5a28b7 445B / 445B                                                                          1.1s
 => => extracting sha256:82c0e88b37bacc0006df84edd0b6aed34f11f5392078539f9999b0fb5d7a5939                                                                           1.7s
 => => extracting sha256:3f4550e9f92dc34790c242052e1ef3b2b5614baf200f1125063c16313a8f6a16                                                                           0.1s
 => => extracting sha256:a0178999f9f2ff9194a1cb98029ffff25c527d8872d0f91fe1b38e0fdf5a28b7                                                                           0.0s
 => [build 1/8] FROM docker.io/library/node:22.13@sha256:fa54405993eaa6bab6b6e460f5f3e945a2e2f07942ba31c0e297a7d9c2041f62                                          38.2s
 => => resolve docker.io/library/node:22.13@sha256:fa54405993eaa6bab6b6e460f5f3e945a2e2f07942ba31c0e297a7d9c2041f62                                                 0.0s
 => => sha256:fa54405993eaa6bab6b6e460f5f3e945a2e2f07942ba31c0e297a7d9c2041f62 6.41kB / 6.41kB                                                                      0.0s
 => => sha256:26af90db8ce9f52427193f189368032b7bb4e3a2077c9e9a011f42d3936d4548 2.49kB / 2.49kB                                                                      0.0s
 => => sha256:d9865b91c4377b8d2a551f62673b3aba4f870b3036e54cfe26b817685faec8ca 6.39kB / 6.39kB                                                                      0.0s
 => => sha256:fd0410a2d1aece5360035b61b0a60d8d6ce56badb9d30a5c86113b3ec724f72a 48.48MB / 48.48MB                                                                    9.8s
 => => sha256:bf571be90f05e10949e4ae13071c81d3182077d926e3f84169a12e0ce2aec209 24.06MB / 24.06MB                                                                    5.1s
 => => sha256:684a51896c8291a1769034cf6e10971c82a82c43b6b4588d1c71d215953eaa61 64.40MB / 64.40MB                                                                   15.2s
 => => sha256:fbf93b646d6b4d6612a25d50599f4d8e3c7785f83c6ba085219f9d4d334e8aa3 211.33MB / 211.33MB                                                                 22.0s
 => => sha256:7253960f3781fcc6d0c42f01b962cf19a1d877a0f01ba5458e5b64a83f606863 3.32kB / 3.32kB                                                                      9.9s
 => => sha256:1ff1d9dbeea3a7bcdcbe189a94e4d0bf50130d9eca157d569a17d8d42d672e4f 55.71MB / 55.71MB                                                                   15.1s
 => => extracting sha256:fd0410a2d1aece5360035b61b0a60d8d6ce56badb9d30a5c86113b3ec724f72a                                                                           2.5s
 => => extracting sha256:bf571be90f05e10949e4ae13071c81d3182077d926e3f84169a12e0ce2aec209                                                                           0.8s
 => => sha256:8eb526287d017e4c280c6ffd4f8825bc5ffcba8ce72de0681a2e1f2b7b22d0b4 1.25MB / 1.25MB                                                                     15.5s
 => => sha256:4ced8847d00f815c6848b966ca728109280a5db6c116099259f8562dfa024e5b 448B / 448B                                                                         15.4s
 => => extracting sha256:684a51896c8291a1769034cf6e10971c82a82c43b6b4588d1c71d215953eaa61                                                                           3.5s
 => => extracting sha256:fbf93b646d6b4d6612a25d50599f4d8e3c7785f83c6ba085219f9d4d334e8aa3                                                                          11.4s
 => => extracting sha256:7253960f3781fcc6d0c42f01b962cf19a1d877a0f01ba5458e5b64a83f606863                                                                           0.0s
 => => extracting sha256:1ff1d9dbeea3a7bcdcbe189a94e4d0bf50130d9eca157d569a17d8d42d672e4f                                                                           3.7s
 => => extracting sha256:8eb526287d017e4c280c6ffd4f8825bc5ffcba8ce72de0681a2e1f2b7b22d0b4                                                                           0.1s
 => => extracting sha256:4ced8847d00f815c6848b966ca728109280a5db6c116099259f8562dfa024e5b                                                                           0.0s
 => [internal] load build context                                                                                                                                   0.5s
 => => transferring context: 1.68MB                                                                                                                                 0.5s
 => [build 2/8] WORKDIR ./src                                                                                                                                       1.3s
 => [build 3/8] COPY . .                                                                                                                                            2.0s
 => [build 4/8] WORKDIR ./frontend                                                                                                                                  0.1s
 => [build 5/8] RUN npm ci && npm run postinstall                                                                                                                 101.1s
 => [build 6/8] RUN npm run build                                                                                                                                 155.5s
 => [build 7/8] RUN mkdir -p ./server/dist &&     echo  > ./server/dist/COMMIT_HASH &&     echo ${DATE} > ./server/dist/BUILD_DATE &&     echo  > ./server/dist/TA  0.3s
 => [build 8/8] RUN ./scripts/yarn-licenses.sh                                                                                                                    263.4s
 => [stage-1 2/6] COPY --from=build ./src/frontend/server /server                                                                                                   3.4s
 => [stage-1 3/6] COPY --from=build ./src/frontend/build /client                                                                                                    0.1s
 => [stage-1 4/6] WORKDIR /server                                                                                                                                   0.1s
 => [stage-1 5/6] RUN npm ci                                                                                                                                       35.9s
 => [stage-1 6/6] RUN npm run build                                                                                                                                 6.9s
 => exporting to image                                                                                                                                              9.2s
 => => exporting layers                                                                                                                                             9.2s
 => => writing image sha256:76c57c5d2a64b41d0caeb63d73c24267ce695d26c11e3d5d4717588148ba39ab                                                                        0.0s
 => => naming to docker.io/library/kfp-frontend:temp                                                                                                                0.0s

 4 warnings found (use --debug to expand):
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 1)
 - WorkdirRelativePath: Relative workdir "./src" can have unexpected results if the base image changes (line 10)
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 38)
 - JSONArgsRecommended: JSON arguments recommended for CMD to prevent unintended behavior related to OS signals (line 39)
pipelines on  fix-node [$?] via 🐹 v1.22.0 via 🐍 v3.10.14 (pipelines) took 10m28s ❯ 
pipelines on  fix-node [$?] via 🐹 v1.22.0 via 🐍 v3.10.14 (pipelines) ❯ echo $?                                
0

@HumairAK
Copy link
Collaborator

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HumairAK HumairAK added the ci-passed All CI tests on a pull request have passed label Jan 15, 2025
@google-oss-prow google-oss-prow bot merged commit 533a3c6 into kubeflow:master Jan 15, 2025
27 checks passed
HumairAK pushed a commit to HumairAK/data-science-pipelines that referenced this pull request Jan 15, 2025
HumairAK pushed a commit to HumairAK/data-science-pipelines that referenced this pull request Jan 15, 2025
google-oss-prow bot pushed a commit that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed All CI tests on a pull request have passed lgtm size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants