Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backend): Fixed namespace in job creation #11480

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

hbelmiro
Copy link
Contributor

@hbelmiro hbelmiro commented Dec 20, 2024

When creating recurring runs, the ScheduledWorkflow CR is created with no namespace set.
This PR changes the CreateJob method so the namespace is set in the Job before creating the ScheduledWorkflow.

Checklist:

Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@VaniHaripriya
Copy link
Contributor

/lgtm

Copy link

@franciscojavierarceo franciscojavierarceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hbelmiro
Copy link
Contributor Author

@HumairAK can you PTAL?

@rimolive
Copy link
Member

/lgtm

@HumairAK
Copy link
Collaborator

HumairAK commented Jan 8, 2025

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: franciscojavierarceo, HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 72f11d9 into kubeflow:master Jan 8, 2025
34 checks passed
@hbelmiro hbelmiro deleted the fix-swf-namespace branch January 8, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants