-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): Disable GKE Metadata as default Fixes: #11247, fixes #11260 #11403
fix(ui): Disable GKE Metadata as default Fixes: #11247, fixes #11260 #11403
Conversation
Hi @dvcanton. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dvcanton can you take a look at the failing tests? |
2c494c6
to
9efbcec
Compare
…ubeflow#11260 Signed-off-by: Dave Canton <[email protected]>
9efbcec
to
e94d260
Compare
Hi @hbelmiro, thanks for the heads up. I have looked into the frontend server tests. They all pass locally now.
|
@dvcanton thank you! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
Fixes: #11247 & #11260
Duplicated from #11321 to include tests.
Checklist: