Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix release note #11337

Merged
merged 2 commits into from
Oct 29, 2024
Merged

chore: fix release note #11337

merged 2 commits into from
Oct 29, 2024

Conversation

chensun
Copy link
Member

@chensun chensun commented Oct 29, 2024

Description of your changes:
#11326 was a SDK change, but added release note to google-cloud component

Checklist:

Signed-off-by: Chen Sun <[email protected]>
Signed-off-by: Chen Sun <[email protected]>
@chensun
Copy link
Member Author

chensun commented Oct 29, 2024

/cc @HumairAK @leseb

@google-oss-prow google-oss-prow bot requested a review from HumairAK October 29, 2024 18:06
Copy link

@chensun: GitHub didn't allow me to request PR reviews from the following users: leseb.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @HumairAK @leseb

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot added the ci-passed All CI tests on a pull request have passed label Oct 29, 2024
@gregsheremeta
Copy link
Contributor

/lgtm

nice catch, thanks :)

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit c81c61e into master Oct 29, 2024
14 checks passed
@google-oss-prow google-oss-prow bot deleted the chensun-patch-7 branch October 29, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed All CI tests on a pull request have passed lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants