Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): fixes flaky tests in CompareV2 resulting in false failures in PRs. Fixes #10811 #11170

Closed
wants to merge 5 commits into from
Closed

fix(frontend): fixes flaky tests in CompareV2 resulting in false failures in PRs. Fixes #10811 #11170

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
54f04e8
fix: Flaky tests in CompareV2 resulting in false failures in PRs #10811
Sep 5, 2024
11ad5b4
first try to see flaky tests
Sep 5, 2024
66a229a
first try to see flaky tests
Sep 5, 2024
98a3427
second try to see flaky tests
Sep 5, 2024
c07478f
third try to see flaky tests
Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/pages/CompareV2.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,8 +420,8 @@ describe('CompareV2', () => {
</CommonTestWrapper>,
);
expect(screen.queryAllByRole('circularprogress')).toHaveLength(2);

await TestUtils.flushPromises();

await waitFor(() => {
screen.getByText('There are no Parameters available on the selected runs.');
screen.getByText('An error is preventing the Scalar Metrics from being displayed.');
Expand Down
Loading