Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Add new ResourceSpec proto fields to support dynamic values. #11075

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

KevinGrantLee
Copy link
Contributor

Description of your changes:

Adds the fields resource_cpu_limit, resource_cpu_request, resource_memory_limit, resource_memory_request, resource_accelerator_type, and resource_accelerator_count.

Checklist:

@KevinGrantLee KevinGrantLee requested review from chensun and removed request for zijianjoy and connor-mccarthy August 5, 2024 21:33
@KevinGrantLee KevinGrantLee changed the title feat: Add new ResourceSpec proto fields to support dynamic values. feat(backend): Add new ResourceSpec proto fields to support dynamic values. Aug 5, 2024
Copy link
Contributor

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: KevinGrantLee <[email protected]>
@google-oss-prow google-oss-prow bot removed the lgtm label Aug 6, 2024
@KevinGrantLee KevinGrantLee requested a review from DharmitD August 6, 2024 07:43
@chensun chensun changed the title feat(backend): Add new ResourceSpec proto fields to support dynamic values. feat(api): Add new ResourceSpec proto fields to support dynamic values. Aug 6, 2024
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 83dcf1a into master Aug 6, 2024
14 checks passed
@google-oss-prow google-oss-prow bot deleted the kglee-proto branch August 6, 2024 22:49
droctothorpe pushed a commit to droctothorpe/pipelines that referenced this pull request Aug 13, 2024
R3hankhan123 pushed a commit to R3hankhan123/pipelines that referenced this pull request Sep 20, 2024
rimolive added a commit to rimolive/data-science-pipelines that referenced this pull request Nov 19, 2024
Introduced back the functions to convert k8s size values to float, but
moved to kfp.dsl.utils

Signed-off-by: Ricardo M. Oliveira <[email protected]>
rimolive added a commit to rimolive/data-science-pipelines that referenced this pull request Nov 19, 2024
Introduced back the functions to convert k8s size values to float, but
moved to kfp.dsl.utils

Signed-off-by: Ricardo M. Oliveira <[email protected]>
rimolive added a commit to rimolive/data-science-pipelines that referenced this pull request Nov 19, 2024
Introduced back the functions to convert k8s size values to float, but
moved to kfp.dsl.utils

Signed-off-by: Ricardo M. Oliveira <[email protected]>
rimolive added a commit to rimolive/data-science-pipelines that referenced this pull request Nov 19, 2024
Introduced back the functions to convert k8s size values to float, but
moved to kfp.dsl.utils

Signed-off-by: Ricardo M. Oliveira <[email protected]>
rimolive added a commit to rimolive/data-science-pipelines that referenced this pull request Nov 19, 2024
Introduced back the functions to convert k8s size values to float, but
moved to kfp.dsl.utils

Signed-off-by: Ricardo M. Oliveira <[email protected]>
rimolive added a commit to rimolive/data-science-pipelines that referenced this pull request Nov 19, 2024
Introduced back the functions to convert k8s size values to float, but
moved to kfp.dsl.utils

Signed-off-by: Ricardo M. Oliveira <[email protected]>
rimolive added a commit to rimolive/data-science-pipelines that referenced this pull request Nov 20, 2024
Introduced back the functions to convert k8s size values to float, but
moved to kfp.dsl.utils

Signed-off-by: Ricardo M. Oliveira <[email protected]>
rimolive added a commit to rimolive/data-science-pipelines that referenced this pull request Nov 20, 2024
Introduced back the functions to convert k8s size values to float, but
moved to kfp.dsl.utils

Signed-off-by: Ricardo M. Oliveira <[email protected]>
rimolive added a commit to rimolive/data-science-pipelines that referenced this pull request Nov 20, 2024
Introduced back the functions to convert k8s size values to float, but
moved to kfp.dsl.utils

Signed-off-by: Ricardo M. Oliveira <[email protected]>
rimolive added a commit to rimolive/data-science-pipelines that referenced this pull request Nov 20, 2024
Introduced back the functions to convert k8s size values to float, but
moved to kfp.dsl.utils

Signed-off-by: Ricardo M. Oliveira <[email protected]>
rimolive added a commit to rimolive/data-science-pipelines that referenced this pull request Nov 20, 2024
Introduced back the functions to convert k8s size values to float, but
moved to kfp.dsl.utils

Signed-off-by: Ricardo M. Oliveira <[email protected]>
rimolive added a commit to rimolive/data-science-pipelines that referenced this pull request Nov 20, 2024
Introduced back the functions to convert k8s size values to float, but
moved to kfp.dsl.utils

Signed-off-by: Ricardo M. Oliveira <[email protected]>
rimolive added a commit to rimolive/data-science-pipelines that referenced this pull request Nov 20, 2024
Introduced back the functions to convert k8s size values to float, but
moved to kfp.dsl.utils

Signed-off-by: Ricardo M. Oliveira <[email protected]>
rimolive added a commit to rimolive/data-science-pipelines that referenced this pull request Nov 25, 2024
Introduced back the functions to convert k8s size values to float, but
moved to kfp.dsl.utils

Signed-off-by: Ricardo M. Oliveira <[email protected]>
rimolive added a commit to rimolive/data-science-pipelines that referenced this pull request Nov 25, 2024
Introduced back the functions to convert k8s size values to float, but
moved to kfp.dsl.utils

Signed-off-by: Ricardo M. Oliveira <[email protected]>
rimolive added a commit to rimolive/data-science-pipelines that referenced this pull request Dec 3, 2024
Introduced back the functions to convert k8s size values to float, but
moved to kfp.dsl.utils

Signed-off-by: Ricardo M. Oliveira <[email protected]>
google-oss-prow bot pushed a commit that referenced this pull request Dec 3, 2024
Introduced back the functions to convert k8s size values to float, but
moved to kfp.dsl.utils

Signed-off-by: Ricardo M. Oliveira <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants