test: Moved kubeflow-pipelines-manifests to GitHub Actions #11066

VaniHaripriya · 2024-08-02T00:34:21Z

Description of your changes:
Moved kubeflow-pipelines-manifests to GitHub Actions.

Resolves #11051

Implementation Notes

Removed installation for kustomize and installed 5.2.1 version as it comes with 5.4.3 version in google-github-actions/setup-gcloud@v2:latest
Added a step to install kpt as its not available in google-github-actions/setup-gcloud@v2:latest

PR to update GoogleCloudPlatform/oss-test-infra

chore: Remove KFP presubmit kubeflow-pipelines-manifests tests prow config GoogleCloudPlatform/oss-test-infra#2336

Checklist:

The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

google-oss-prow · 2024-08-02T00:34:32Z

Hi @VaniHaripriya. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hbelmiro · 2024-08-02T11:40:32Z

/ok-to-test

hbelmiro

@VaniHaripriya have you noticed that there are failing tests?
Also, you need to sign off your commits.

hbelmiro · 2024-08-02T11:43:47Z

@VaniHaripriya FYI the kubeflow-pipelines-manifests Prow test will disappear from the checks after a rebase when GoogleCloudPlatform/oss-test-infra#2336 gets merged.

.github/workflows/kubeflow-pipelines-manifests.yml

hbelmiro · 2024-08-02T17:16:19Z

cc @DharmitD

DharmitD · 2024-08-02T17:21:42Z

.github/workflows/kubeflow-pipelines-manifests.yml

+          version: 'latest'
+
+      - name: Run tests
+        run: ./manifests/kustomize/hack/presubmit.sh


nitpick: Fix EoF here.

hbelmiro · 2024-08-02T17:22:36Z

manifests/kustomize/hack/presubmit.sh

+# Install kpt
+KPT_VERSION=1.0.0-beta.54
+# Reference: https://github.com/GoogleContainerTools/kpt/releases/tag/v1.0.0-beta.54
+curl -s -LO "https://github.com/GoogleContainerTools/kpt/releases/download/v${KPT_VERSION}/kpt_linux_amd64"


Can we use the new repo here?
https://github.com/kptdev/kpt

hbelmiro · 2024-08-02T17:24:58Z

manifests/kustomize/hack/presubmit.sh

+# kustomize and kubectl should already be installed in google-github-actions/setup-gcloud@v2:latest
 # so we do not need to install them here


We can remove this comment. If I'm not mistaken, the Ubuntu GitHub runner has them.

.github/workflows/kubeflow-pipelines-manifests.yml

hbelmiro · 2024-08-02T17:28:01Z

.github/workflows/kubeflow-pipelines-manifests.yml

+      - name: Set up Cloud SDK
+        uses: google-github-actions/setup-gcloud@v2
+        with:
+          version: 'latest'


We're not supposed to need this step. Did you try to run without it?

It worked with out this step.Thank you!

hbelmiro · 2024-08-02T19:06:03Z

@VaniHaripriya FYI, I just confirmed that the e2e tests are failing :(
#11069

VaniHaripriya · 2024-08-02T20:34:28Z

@VaniHaripriya FYI, I just confirmed that the e2e tests are failing :( #11069

Thank you @hbelmiro !

hbelmiro

/lgtm

hbelmiro · 2024-08-05T12:38:32Z

@zijianjoy we need your approval due to a change under manifests/kustomize.

hbelmiro · 2024-08-05T19:33:21Z

@VaniHaripriya, I fixed the e2e tests. Can you please rebase?

hbelmiro

/lgtm

DharmitD

/Approve

diegolovison

I believe my two comments should be addressed

diegolovison · 2024-08-05T23:09:53Z

manifests/kustomize/hack/presubmit.sh

+# Remove existing kustomize if it exists
+if [ -f "/usr/local/bin/kustomize" ]; then
+    echo "Removing existing kustomize from /usr/local/bin"
+    sudo rm /usr/local/bin/kustomize


This is dangerous. You can download kustomize and add it to the PATH

Example:

Download everything into the created temp folder https://github.com/kubeflow/pipelines/blob/master/manifests/kustomize/hack/presubmit.sh#L22
then,

PATH="$TMP:$PATH"

In this case, your downloaded binaries will be available for use without breaking your local environment.

diegolovison · 2024-08-05T23:11:17Z

manifests/kustomize/hack/presubmit.sh

+# Reference: https://github.com/kptdev/kpt/releases/tag/v1.0.0-beta.54
+curl -s -LO "https://github.com/kptdev/kpt/releases/download/v${KPT_VERSION}/kpt_linux_amd64"
+chmod +x kpt_linux_amd64
+mv kpt_linux_amd64 /usr/local/bin/kpt


Maybe create a folder at home and add kpt there.
Set that folder to the PATH variable

@diegolovison All the binaries are installed in temp directory. So in my opinion kpt doesn't require another folder.

If all binaries are installed in the temp folder, IMHO, it is better to use those instead of mv kpt_linux_amd64 /usr/local/bin/kpt

hbelmiro · 2024-08-07T17:43:02Z

/rerun-all

Signed-off-by: vmudadla <[email protected]>

diegolovison · 2024-08-12T16:45:43Z

/lgtm

gregsheremeta · 2024-08-13T14:23:07Z

@hbelmiro @DharmitD this good to ship?

hbelmiro · 2024-08-13T14:38:54Z

@hbelmiro @DharmitD this good to ship?

Yes. We just need @zijianjoy's approval.

zijianjoy · 2024-08-14T18:05:18Z

/lgtm
/approve

Thank you for the change!
(something to be improved in the future is to check the git diff output automatically in https://github.com/kubeflow/pipelines/blob/master/manifests/kustomize/hack/presubmit.sh#L46-L49. But that is a different task)

google-oss-prow · 2024-08-14T18:05:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DharmitD, diegolovison, zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~.github/OWNERS~~ [DharmitD,zijianjoy]
~~manifests/kustomize/OWNERS~~ [zijianjoy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: vmudadla <[email protected]> Signed-off-by: KevinGrantLee <[email protected]>

…11066) Signed-off-by: vmudadla <[email protected]>

@DharmitD

…etters (#11097) * temp title: change title Signed-off-by: KevinGrantLee <[email protected]> * add release notes Signed-off-by: KevinGrantLee <[email protected]> * formatting Signed-off-by: KevinGrantLee <[email protected]> * feat(backend): move comp logic to workflow params (#10979) * feat(backend): move comp logic to workflow params Signed-off-by: zazulam <[email protected]> Co-authored-by: droctothorpe <[email protected]> Co-authored-by: andreafehrman <[email protected]> Co-authored-by: MonicaZhang1 <[email protected]> Co-authored-by: kylekaminky <[email protected]> Co-authored-by: CarterFendley <[email protected]> Signed-off-by: zazulam <[email protected]> * address pr comments Signed-off-by: zazulam <[email protected]> * Use function name instead of base name and address edge cases Signed-off-by: droctothorpe <[email protected]> Co-authored-by: zazulam <[email protected]> * Improve logic and update tests Signed-off-by: droctothorpe <[email protected]> Co-authored-by: zazulam <[email protected]> * POC hashing command and args Signed-off-by: droctothorpe <[email protected]> Co-authored-by: zazulam <[email protected]> * Add comments to clarify the logic Signed-off-by: droctothorpe <[email protected]> Co-authored-by: zazulam <[email protected]> * Hash entire PipelineContainerSpec Signed-off-by: droctothorpe <[email protected]> Co-authored-by: zazulam <[email protected]> --------- Signed-off-by: zazulam <[email protected]> Signed-off-by: droctothorpe <[email protected]> Co-authored-by: droctothorpe <[email protected]> Co-authored-by: andreafehrman <[email protected]> Co-authored-by: MonicaZhang1 <[email protected]> Co-authored-by: kylekaminky <[email protected]> Co-authored-by: CarterFendley <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * feat(component): internal Signed-off-by: Googler <[email protected]> PiperOrigin-RevId: 660985413 Signed-off-by: KevinGrantLee <[email protected]> * feat(components): internal Signed-off-by: Googler <[email protected]> PiperOrigin-RevId: 661332120 Signed-off-by: KevinGrantLee <[email protected]> * fix(components): Fix to model batch explanation component for Structured Data pipelines Signed-off-by: Googler <[email protected]> PiperOrigin-RevId: 661475667 Signed-off-by: KevinGrantLee <[email protected]> * feat(components): Support dynamic values for boot_disk_type, boot_disk_size in preview.custom_job.utils.create_custom_training_job_from_component Signed-off-by: Googler <[email protected]> PiperOrigin-RevId: 662242688 Signed-off-by: KevinGrantLee <[email protected]> * chore: Upgrade Argo to v3.4.17 (#10978) Signed-off-by: Giulio Frasca <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * test: Moved kubeflow-pipelines-manifests to GitHub Actions (#11066) Signed-off-by: vmudadla <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * fix: re-enable exit hanler test. (#11100) Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]> Co-authored-by: Liav Weiss (EXT-Nokia) <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * fix(frontend): retrieve archived logs from correct location (#11010) * fix(frontend): retrieve archived logs from correct location Signed-off-by: droctothorpe <[email protected]> Co-authored-by: andreafehrman <[email protected]> Co-authored-by: owmasch <[email protected]> * Add namespace tag handling and validation Signed-off-by: droctothorpe <[email protected]> Co-authored-by: andreafehrman <[email protected]> Co-authored-by: owmasch <[email protected]> * Remove whitespace from keyFormat Signed-off-by: droctothorpe <[email protected]> Co-authored-by: andreafehrman <[email protected]> Co-authored-by: owmasch <[email protected]> * Update frontend unit tests Signed-off-by: droctothorpe <[email protected]> * Remove superfluous log statements Signed-off-by: droctothorpe <[email protected]> Co-authored-by: quinnovator <[email protected]> * Add link to keyFormat in manifests Signed-off-by: droctothorpe <[email protected]> * Fix workflow parsing for log artifact Signed-off-by: droctothorpe <[email protected]> Co-authored-by: quinnovator <[email protected]> * Fix unit test Signed-off-by: droctothorpe <[email protected]> --------- Signed-off-by: droctothorpe <[email protected]> Co-authored-by: andreafehrman <[email protected]> Co-authored-by: owmasch <[email protected]> Co-authored-by: quinnovator <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * feat(component): internal Signed-off-by: Googler <[email protected]> PiperOrigin-RevId: 663774557 Signed-off-by: KevinGrantLee <[email protected]> * feat(component): internal Signed-off-by: Googler <[email protected]> PiperOrigin-RevId: 663872006 Signed-off-by: KevinGrantLee <[email protected]> * chore(components): GCPC 2.16.1 Release Signed-off-by: Googler <[email protected]> PiperOrigin-RevId: 663883139 Signed-off-by: KevinGrantLee <[email protected]> * test: Fail fast when image build fails on tests #11102 (#11115) * Fail fast when image build fails on tests #11102 Signed-off-by: Elay Aharoni (EXT-Nokia) <[email protected]> * Fail fast when image build fails on tests #11102 Signed-off-by: Elay Aharoni (EXT-Nokia) <[email protected]> --------- Signed-off-by: Elay Aharoni (EXT-Nokia) <[email protected]> Co-authored-by: Elay Aharoni (EXT-Nokia) <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * fix(components): Use instance.target_field_name format for text-bison models only, use target_field_name for gemini models Signed-off-by: Googler <[email protected]> PiperOrigin-RevId: 665638487 Signed-off-by: KevinGrantLee <[email protected]> * chore: Renamed GitHub workflows from *.yaml to *.yml for consistency (#11126) Signed-off-by: hbelmiro <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * Fix view edit cluster roles (#11067) * Fixing incorrect typing in loop_parallism example Signed-off-by: Oswaldo Gomez <[email protected]> * Fixing samples/core/loop_parameter example Signed-off-by: Oswaldo Gomez <[email protected]> * Fixing aggregate-to-kubeflow-pipelines-edit Signed-off-by: Oswaldo Gomez <[email protected]> * keeping MRs separate. Signed-off-by: Oswaldo Gomez <[email protected]> * Adding blank line Signed-off-by: Oswaldo Gomez <[email protected]> --------- Signed-off-by: Oswaldo Gomez <[email protected]> Co-authored-by: Oswaldo Gomez <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * fix(components): Pass moddel name to eval_runner to process batch prediction's output as per the output schema of model used Signed-off-by: Googler <[email protected]> PiperOrigin-RevId: 665977093 Signed-off-by: KevinGrantLee <[email protected]> * feat(components): release LLM Model Evaluation image version v0.7 Signed-off-by: Jason Dai <[email protected]> PiperOrigin-RevId: 666102687 Signed-off-by: KevinGrantLee <[email protected]> * chore: Adding @DharmitD to SDK reviewers (#11131) Signed-off-by: ddalvi <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * test: Kubeflow Pipelines V2 integration Tests (#11125) Signed-off-by: Diego Lovison <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * chore: Add make targets for building driver and launcher images (#11103) Signed-off-by: Giulio Frasca <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * feat(Backend + SDK): Update kfp backend and kubernetes sdk to support EmptyDir (#10913) Update kfp backend and kubernetes sdk to support mounting EmptyDir volumes to task pods. Inspired by #10427 Fixes: #10656 Signed-off-by: Greg Sheremeta <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * docs:fixing broken links in readme (#11108) Signed-off-by: Fiona Waters <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * chore(deps): bump micromatch from 4.0.5 to 4.0.8 in /test/frontend-integration-test (#11132) Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.5 to 4.0.8. - [Release notes](https://github.com/micromatch/micromatch/releases) - [Changelog](https://github.com/micromatch/micromatch/blob/4.0.8/CHANGELOG.md) - [Commits](micromatch/micromatch@4.0.5...4.0.8) --- updated-dependencies: - dependency-name: micromatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: KevinGrantLee <[email protected]> * Fix: Basic sample tests - sequential is flaky (#11138) Signed-off-by: Diego Lovison <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * chore: Wrapped "Failed GetContextByTypeAndName" error for better troubleshooting (#11098) Signed-off-by: hbelmiro <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * chore(components): Update AutoSxS and RLHF image tags Signed-off-by: Michael Hu <[email protected]> PiperOrigin-RevId: 668536503 Signed-off-by: KevinGrantLee <[email protected]> * test: Improvements to wait_for_pods function (#11162) Signed-off-by: hbelmiro <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * fix(frontend): fixes filter pipeline text box shows error when typing anything in it. Fixes #10241 (#11096) * Filter pipeline text box shows error when typing anything in it #10241 Signed-off-by: Elay Aharoni (EXT-Nokia) <[email protected]> * Filter pipeline text box shows error when typing anything in it #10241 Signed-off-by: Elay Aharoni (EXT-Nokia) <[email protected]> --------- Signed-off-by: Elay Aharoni (EXT-Nokia) <[email protected]> Co-authored-by: Elay Aharoni (EXT-Nokia) <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * correct artifact preview behavior in UI (#11059) This change allows KFP UI to fallback to UI host namespace when no namespaces are provided when referencing the artifact object store provider secret, in default kubeflow deployments this namespace is simply "kubeflow", however the user can customize this behavior by providing the environment variable "SERVER_NAMESPACE" to the KFP UI deployment. Further more, this change addresses a bug that caused URL parse to fail when parsing endpoints without a protocol, this will support such endpoint types as <ip>:<port> for object store endpoints, as is the case in the default kfp deployment manifests. Signed-off-by: Humair Khan <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * chore: Added DCO link to PR template (#11176) Signed-off-by: Helber Belmiro <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * chore(backend): Update driver and launcher licenses (#11177) Signed-off-by: Chen Sun <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * chore(backend): update driver and launcher default images (#11178) Signed-off-by: Chen Sun <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * chore: Add instructions for releasing driver and launcher images (#11179) Signed-off-by: Chen Sun <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * test: Fixed `kfp-runtime-tests` to run on master branch (#11158) Signed-off-by: hbelmiro <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * (fix): reduce executor logs (#11169) * remove driver logs from executor These logs congest the executor runtime logs making it difficult for the user to differentiate between logs. The driver logs are unnecessary here and can be removed to reduce this clutter. Signed-off-by: Humair Khan <[email protected]> * remove duplicate emissary call in executor As per the initial inline dev comment, argo podspecpatch did not add the emissary call, and had to be manualy added. This was fixed a couple of argo versions back. However, as a result executor pod makes double calls to the executor, which as a consequence also results in superflous logs. This change removes the additional call to emissary to resolve this. Signed-off-by: Humair Khan <[email protected]> --------- Signed-off-by: Humair Khan <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * chore: add PaulinaPacyna and ouadakarim as reviewers (#11180) Signed-off-by: Chen Sun <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * test: Move run-all-gcpc-modules to GitHub Actions (#11157) * add gcpc modules tests to gha Signed-off-by: Amanpreet Singh Bedi <[email protected]> * remove run-all-gcpc-modules test driver script Signed-off-by: Amanpreet Singh Bedi <[email protected]> * fix path under gcpc modules tests github action Signed-off-by: Amanpreet Singh Bedi <[email protected]> * upgrade ubuntu base image Signed-off-by: Amanpreet Singh Bedi <[email protected]> * upgrade python version to 3.9 Signed-off-by: Amanpreet Singh Bedi <[email protected]> --------- Signed-off-by: Amanpreet Singh Bedi <[email protected]> Signed-off-by: Amanpreet Singh Bedi <[email protected]> Co-authored-by: Amanpreet Singh Bedi <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * fix(sdk): Kfp support for pip trusted host (#11151) Signed-off-by: Diego Lovison <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * chore(sdk): Loosening kubernetes dependency constraint (#11079) * Loosening kubernetes dependency constraint Signed-off-by: egeucak <[email protected]> * added setuptools in test script Signed-off-by: egeucak <[email protected]> --------- Signed-off-by: egeucak <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * chore: Remove unwanted Frontend test files (#10973) Signed-off-by: ddalvi <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * fix(ui): fixes empty string value in pipeline parameters (#11175) Signed-off-by: Jan Staněk <[email protected]> Co-authored-by: Jan Staněk <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * chore(backend): update driver and launcher default images (#11182) Signed-off-by: Chen Sun <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * chore(release): bumped version to 2.3.0 Signed-off-by: KevinGrantLee <[email protected]> * chore: Update RELEASE.md to remove obsolete instructions (#11183) Signed-off-by: Chen Sun <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * chore: Release kfp-pipeline-spec 0.4.0 (#11189) Signed-off-by: Chen Sun <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * chore: release kfp-kubernetes 1.3.0 (#11190) Signed-off-by: Chen Sun <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * chore: update kfp-kubernetes release scripts and instructions (#11191) Signed-off-by: Chen Sun <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * feat(sdk)!: Pin kfp-pipeline-spec==0.4.0, kfp-server-api>=2.1.0,<2.4.0 (#11192) Signed-off-by: Chen Sun <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * chore(sdk): release KFP SDK 2.9.0 (#11193) Signed-off-by: Chen Sun <[email protected]> Signed-off-by: KevinGrantLee <[email protected]> * Delete test pipelines as they are duplicate with pipeline_with_resource_spec Signed-off-by: KevinGrantLee <[email protected]> --------- Signed-off-by: KevinGrantLee <[email protected]> Signed-off-by: zazulam <[email protected]> Signed-off-by: droctothorpe <[email protected]> Signed-off-by: Googler <[email protected]> Signed-off-by: Giulio Frasca <[email protected]> Signed-off-by: vmudadla <[email protected]> Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]> Signed-off-by: Elay Aharoni (EXT-Nokia) <[email protected]> Signed-off-by: hbelmiro <[email protected]> Signed-off-by: Oswaldo Gomez <[email protected]> Signed-off-by: Jason Dai <[email protected]> Signed-off-by: ddalvi <[email protected]> Signed-off-by: Diego Lovison <[email protected]> Signed-off-by: Greg Sheremeta <[email protected]> Signed-off-by: Fiona Waters <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Michael Hu <[email protected]> Signed-off-by: Humair Khan <[email protected]> Signed-off-by: Helber Belmiro <[email protected]> Signed-off-by: Chen Sun <[email protected]> Signed-off-by: Amanpreet Singh Bedi <[email protected]> Signed-off-by: Amanpreet Singh Bedi <[email protected]> Signed-off-by: egeucak <[email protected]> Signed-off-by: Jan Staněk <[email protected]> Co-authored-by: Michael <[email protected]> Co-authored-by: droctothorpe <[email protected]> Co-authored-by: andreafehrman <[email protected]> Co-authored-by: MonicaZhang1 <[email protected]> Co-authored-by: kylekaminky <[email protected]> Co-authored-by: CarterFendley <[email protected]> Co-authored-by: Googler <[email protected]> Co-authored-by: Giulio Frasca <[email protected]> Co-authored-by: Vani Haripriya Mudadla <[email protected]> Co-authored-by: Liav Weiss <[email protected]> Co-authored-by: Liav Weiss (EXT-Nokia) <[email protected]> Co-authored-by: owmasch <[email protected]> Co-authored-by: quinnovator <[email protected]> Co-authored-by: ElayAharoni <[email protected]> Co-authored-by: Elay Aharoni (EXT-Nokia) <[email protected]> Co-authored-by: Helber Belmiro <[email protected]> Co-authored-by: Oswaldo Gomez <[email protected]> Co-authored-by: Oswaldo Gomez <[email protected]> Co-authored-by: Jason Dai <[email protected]> Co-authored-by: Dharmit Dalvi <[email protected]> Co-authored-by: Diego Lovison <[email protected]> Co-authored-by: Greg Sheremeta <[email protected]> Co-authored-by: Fiona Waters <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michael Hu <[email protected]> Co-authored-by: Humair Khan <[email protected]> Co-authored-by: Chen Sun <[email protected]> Co-authored-by: aman23bedi <[email protected]> Co-authored-by: Amanpreet Singh Bedi <[email protected]> Co-authored-by: ege uçak <[email protected]> Co-authored-by: Jan Staněk <[email protected]> Co-authored-by: Jan Staněk <[email protected]>

google-oss-prow bot requested review from rimolive and zijianjoy August 2, 2024 00:34

google-oss-prow bot added size/M needs-ok-to-test labels Aug 2, 2024

VaniHaripriya mentioned this pull request Aug 2, 2024

chore: Remove KFP presubmit kubeflow-pipelines-manifests tests prow config GoogleCloudPlatform/oss-test-infra#2336

Merged

google-oss-prow bot added ok-to-test and removed needs-ok-to-test labels Aug 2, 2024

hbelmiro reviewed Aug 2, 2024

View reviewed changes

VaniHaripriya force-pushed the kfp-manifests-tests-gha branch 3 times, most recently from 6c7dd13 to abae5de Compare August 2, 2024 16:30

hbelmiro reviewed Aug 2, 2024

View reviewed changes

.github/workflows/kubeflow-pipelines-manifests.yml Show resolved Hide resolved

DharmitD reviewed Aug 2, 2024

View reviewed changes

hbelmiro reviewed Aug 2, 2024

View reviewed changes

VaniHaripriya force-pushed the kfp-manifests-tests-gha branch from c70607b to 5e21254 Compare August 2, 2024 20:31

hbelmiro reviewed Aug 5, 2024

View reviewed changes

google-oss-prow bot assigned hbelmiro Aug 5, 2024

google-oss-prow bot added the lgtm label Aug 5, 2024

VaniHaripriya force-pushed the kfp-manifests-tests-gha branch from 5e21254 to 870bb6f Compare August 5, 2024 20:06

google-oss-prow bot removed the lgtm label Aug 5, 2024

hbelmiro reviewed Aug 5, 2024

View reviewed changes

google-oss-prow bot added the lgtm label Aug 5, 2024

google-oss-prow bot removed the lgtm label Aug 5, 2024

VaniHaripriya force-pushed the kfp-manifests-tests-gha branch from f0e3ded to d9f7086 Compare August 5, 2024 21:15

DharmitD approved these changes Aug 5, 2024

View reviewed changes

diegolovison suggested changes Aug 5, 2024

View reviewed changes

Moved kubeflow-pipelines-manifests to GitHub Actions

c6510ac

Signed-off-by: vmudadla <[email protected]>

VaniHaripriya force-pushed the kfp-manifests-tests-gha branch from 8a85ef7 to c6510ac Compare August 12, 2024 16:45

google-oss-prow bot assigned diegolovison Aug 12, 2024

google-oss-prow bot added the lgtm label Aug 12, 2024

diegolovison approved these changes Aug 12, 2024

View reviewed changes

google-oss-prow bot assigned zijianjoy Aug 14, 2024

google-oss-prow bot added the approved label Aug 14, 2024

chensun mentioned this pull request Aug 14, 2024

Remove kubeflow-pipelines-manifests from kubeflow-pipelines-presubmit… GoogleCloudPlatform/oss-test-infra#2345

Closed

chensun merged commit 4458bdd into kubeflow:master Aug 14, 2024
12 of 14 checks passed

hbelmiro mentioned this pull request Aug 14, 2024

Move kubeflow-pipelines-manifests to GitHub Actions #11051

Closed

KevinGrantLee pushed a commit that referenced this pull request Sep 17, 2024

test: Moved kubeflow-pipelines-manifests to GitHub Actions (#11066)

90df1c4

Signed-off-by: vmudadla <[email protected]> Signed-off-by: KevinGrantLee <[email protected]>

R3hankhan123 pushed a commit to R3hankhan123/pipelines that referenced this pull request Sep 20, 2024

test: Moved kubeflow-pipelines-manifests to GitHub Actions (kubeflow#…

54cecf8

…11066) Signed-off-by: vmudadla <[email protected]>

This was referenced Oct 17, 2024

Add VaniHaripriya as a Kubeflow Member kubeflow/internal-acls#719

Closed

Add VaniHaripriya as a Kubeflow Member kubeflow/internal-acls#720

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Moved kubeflow-pipelines-manifests to GitHub Actions #11066

test: Moved kubeflow-pipelines-manifests to GitHub Actions #11066

VaniHaripriya commented Aug 2, 2024 •

edited

Loading

google-oss-prow bot commented Aug 2, 2024

hbelmiro commented Aug 2, 2024

hbelmiro left a comment

hbelmiro commented Aug 2, 2024

hbelmiro commented Aug 2, 2024

DharmitD Aug 2, 2024

hbelmiro Aug 2, 2024

hbelmiro Aug 2, 2024

hbelmiro Aug 2, 2024

VaniHaripriya Aug 2, 2024

hbelmiro commented Aug 2, 2024

VaniHaripriya commented Aug 2, 2024

hbelmiro left a comment

hbelmiro commented Aug 5, 2024

hbelmiro commented Aug 5, 2024

hbelmiro left a comment

DharmitD left a comment

diegolovison left a comment

diegolovison Aug 5, 2024 •

edited

Loading

diegolovison Aug 12, 2024

diegolovison Aug 5, 2024

VaniHaripriya Aug 8, 2024

diegolovison Aug 8, 2024

hbelmiro commented Aug 7, 2024

diegolovison commented Aug 12, 2024

gregsheremeta commented Aug 13, 2024

hbelmiro commented Aug 13, 2024

zijianjoy commented Aug 14, 2024

google-oss-prow bot commented Aug 14, 2024

		# kustomize and kubectl should already be installed in google-github-actions/setup-gcloud@v2:latest
		# so we do not need to install them here

test: Moved kubeflow-pipelines-manifests to GitHub Actions #11066

test: Moved kubeflow-pipelines-manifests to GitHub Actions #11066

Conversation

VaniHaripriya commented Aug 2, 2024 • edited Loading

google-oss-prow bot commented Aug 2, 2024

hbelmiro commented Aug 2, 2024

hbelmiro left a comment

Choose a reason for hiding this comment

hbelmiro commented Aug 2, 2024

hbelmiro commented Aug 2, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hbelmiro commented Aug 2, 2024

VaniHaripriya commented Aug 2, 2024

hbelmiro left a comment

Choose a reason for hiding this comment

hbelmiro commented Aug 5, 2024

hbelmiro commented Aug 5, 2024

hbelmiro left a comment

Choose a reason for hiding this comment

DharmitD left a comment

Choose a reason for hiding this comment

diegolovison left a comment

Choose a reason for hiding this comment

diegolovison Aug 5, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hbelmiro commented Aug 7, 2024

diegolovison commented Aug 12, 2024

gregsheremeta commented Aug 13, 2024

hbelmiro commented Aug 13, 2024

zijianjoy commented Aug 14, 2024

google-oss-prow bot commented Aug 14, 2024

VaniHaripriya commented Aug 2, 2024 •

edited

Loading

diegolovison Aug 5, 2024 •

edited

Loading