feat(backend): Upgrade argo to v3.4.16

[gmfrasca]

Description of your changes:
Implements #10469, also Fixes #8935

• Upgrades Argo backend to v3.4.16, latest in the argo v3.4 release stream
• Implements RetrievePodName function to work around NodeStatus.ID issue (see below)
• Updates unit tests accordingly

Note: This PR supercedes #9301, copying description from PR:
Fixes the following CVEs:

https://github.com/advisories/GHSA-4f9f-mpmj-4c52
https://github.com/advisories/GHSA-98w6-hw73-ph8m
CVE-2022-23521
CVE-2022-41903
https://github.com/advisories/GHSA-grfr-78m7-q35q
https://github.com/advisories/GHSA-cfmr-vrgj-vqwv
https://github.com/advisories/GHSA-75qm-2q4j-qx6g

Breaking changes:

- Argo 3.4 removed support for choosing container runtime executors, emissary is the only option left: https://argoproj.github.io/argo-workflows/workflow-executors/
- Argo 3.4 no longer maintains the naming convention of NodeStatus.ID and NodeStatus.Name being identical.  This was addressed in the code changes in `workflow.go`

Notes:

• The fix for the NodeStatus naming bug/breaking change was extracted to a seperate function, such that when it is fixed it can be easily updated in one place. Monitor the fix in argo here: feat: store podname in nodestatus argoproj/argo-workflows#12503
• I believe the containerRuntimeExecutor value in the WorkflowController ConfigMap needs to be removed in all manifests, or else the WC Pod will fail on an invalid input json error. May need assistance testing across all platforms

Checklist:

• The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

[google-oss-prow]

Hi @gmfrasca. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[HumairAK]

/ok-to-test

[rimolive]

/test kubeflow-pipeline-e2e-test

[gmfrasca]

I believe the CI errors are due to the respective Argo images not existing in the gcr.io/ml-pipeline image repository (WorkflowController pod fails to come up because of ImageBackOff error, since the image doesn't exist), since this PR would be the one that updates them.

I'm assuming I don't have permissions to build and publish them to the repository so who would be responsible for taking that action?

[gmfrasca]

Another quick note: When testing this, there was a unit test that was failing (Test_executeV2_Parameters), but this was also the case before any changes made by this PR, so presumably that's out-of-scope here. All other unit tests should pass

[rimolive]

@chensun @zijianjoy Can you push Argo 3.4 images to gcr to ensure test will pass?

[chensun]

@chensun @zijianjoy Can you push Argo 3.4 images to gcr to ensure test will pass?

Done. gcr.io/ml-pipeline/argoexec:v3.4.16-license-compliance and gcr.io/ml-pipeline/workflow-controller:v3.4.16-license-compliance are now available.

#10618

[chensun]

/retest

[rimolive]

/test kubeflow-pipeline-backend-test

[gmfrasca]

looking into the e2e failure but in the meantime, looks like mkp was a network flake so retesting to see if investigation is needed

/test kubeflow-pipeline-mkp-test

[Tomcli]

thanks @gmfrasca
/lgtm

[gmfrasca]

^just addresses the rebase/merge conflicts (only affects go.mod and licenses CSVs)

[HumairAK]

@chensun / @zijianjoy bump, any thing else we can do to help get this PR merged?

[rimolive]

/lgtm

[chensun]

/lgtm
/approve

Thanks!

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun, Tomcli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [chensun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment