Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Change stalebot rules #10547

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

rimolive
Copy link
Member

@rimolive rimolive commented Mar 7, 2024

Description of your changes:
daysUntilClose is set to 90 days. This is too much for an issue to keep opened as there is daysUntilStale set to 90 days. That would keep an issue opened for 6 months, and now there are +600 issues opened in the repository.

We need to start working on keeping the repository healthy.

Checklist:

@rimolive
Copy link
Member Author

rimolive commented Mar 7, 2024

cc @Tomcli @chensun @zijianjoy

@gregsheremeta
Copy link
Contributor

👍 This is a good step towards getting the community back on a healthy track.

@@ -4,7 +4,7 @@
# Number of days of inactivity before an issue becomes stale
daysUntilStale: 90
# Number of days of inactivity before a stale issue is closed
daysUntilClose: 90
daysUntilClose: 7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can use the default value of slate bot which is 21 days? The bigger problem here is many issues are not slate anymore when they reopen.
https://github.com/etcd-io/etcd/blob/main/.github/stale.yml#L9

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can always use /lifecycle frozen for important issues that needs more time, but the fact is that we currently have ~310 issues with lifecycle/stale and ~90 issues with lifecycle/frozen. This number is already unmanageable for the number of contributors we have.

Let me know your thoughts.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for the "many issues are not slate anymore when they reopen", we can also consider setting daysUntilStale to the default 60 days.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rimolive, shorten the daysUntilStale and having a longer daysUntilClose would work better. This way we can warn the issue creator on issues going to stale without closing it too soon.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if these parameters look good:
daysUntilStale: 60
daysUntilClose: 21

daysUntilClose is set to 90 days. This is too much for an issue to keep opened as there is daysUntilStale set to 90 days.
That would keep an issue opened for 6 months, and now there are +600 issues opened in the repository.

We need to start working on keeping the repository healthy.

Signed-off-by: Ricardo M. Oliveira <[email protected]>
Copy link
Member

@Tomcli Tomcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rimolive
Copy link
Member Author

rimolive commented Mar 12, 2024

@chensun @zijianjoy Can you review/approve?

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's test out these parameters. Thanks for taking the lead!

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 8ac0fdb into kubeflow:master Mar 13, 2024
3 checks passed
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 27, 2024
daysUntilClose is set to 90 days. This is too much for an issue to keep opened as there is daysUntilStale set to 90 days.
That would keep an issue opened for 6 months, and now there are +600 issues opened in the repository.

We need to start working on keeping the repository healthy.

Signed-off-by: Ricardo M. Oliveira <[email protected]>
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 29, 2024
daysUntilClose is set to 90 days. This is too much for an issue to keep opened as there is daysUntilStale set to 90 days.
That would keep an issue opened for 6 months, and now there are +600 issues opened in the repository.

We need to start working on keeping the repository healthy.

Signed-off-by: Ricardo M. Oliveira <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants