-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Change stalebot rules #10547
chore: Change stalebot rules #10547
Conversation
👍 This is a good step towards getting the community back on a healthy track. |
.github/stale.yml
Outdated
@@ -4,7 +4,7 @@ | |||
# Number of days of inactivity before an issue becomes stale | |||
daysUntilStale: 90 | |||
# Number of days of inactivity before a stale issue is closed | |||
daysUntilClose: 90 | |||
daysUntilClose: 7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can use the default value of slate bot which is 21 days? The bigger problem here is many issues are not slate anymore when they reopen.
https://github.com/etcd-io/etcd/blob/main/.github/stale.yml#L9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can always use /lifecycle frozen
for important issues that needs more time, but the fact is that we currently have ~310 issues with lifecycle/stale
and ~90 issues with lifecycle/frozen
. This number is already unmanageable for the number of contributors we have.
Let me know your thoughts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As for the "many issues are not slate anymore when they reopen", we can also consider setting daysUntilStale to the default 60 days.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rimolive, shorten the daysUntilStale
and having a longer daysUntilClose
would work better. This way we can warn the issue creator on issues going to stale without closing it too soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if these parameters look good:
daysUntilStale
: 60
daysUntilClose
: 21
daysUntilClose is set to 90 days. This is too much for an issue to keep opened as there is daysUntilStale set to 90 days. That would keep an issue opened for 6 months, and now there are +600 issues opened in the repository. We need to start working on keeping the repository healthy. Signed-off-by: Ricardo M. Oliveira <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@chensun @zijianjoy Can you review/approve? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's test out these parameters. Thanks for taking the lead!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
daysUntilClose is set to 90 days. This is too much for an issue to keep opened as there is daysUntilStale set to 90 days. That would keep an issue opened for 6 months, and now there are +600 issues opened in the repository. We need to start working on keeping the repository healthy. Signed-off-by: Ricardo M. Oliveira <[email protected]>
daysUntilClose is set to 90 days. This is too much for an issue to keep opened as there is daysUntilStale set to 90 days. That would keep an issue opened for 6 months, and now there are +600 issues opened in the repository. We need to start working on keeping the repository healthy. Signed-off-by: Ricardo M. Oliveira <[email protected]>
Description of your changes:
daysUntilClose is set to 90 days. This is too much for an issue to keep opened as there is daysUntilStale set to 90 days. That would keep an issue opened for 6 months, and now there are +600 issues opened in the repository.
We need to start working on keeping the repository healthy.
Checklist: