-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(backend): Fixes response status of http error code when uploading duplicate pipeline [Fixes #10311] #10546
fix(backend): Fixes response status of http error code when uploading duplicate pipeline [Fixes #10311] #10546
Conversation
Hi @champon1020. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Validate the error code of pipeline creation in order to return the status conflict when the error represents AlreadyExists. Signed-off-by: champon1020 <[email protected]>
6090f70
to
64b80b6
Compare
Thank you for your contribution, @champon1020! /ok-to-test |
/lgtm After uploading the same pipeline twice I got this expected error from API:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Tomcli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test kubeflow-pipeline-e2e-test |
… duplicate pipeline [Fixes kubeflow#10311] (kubeflow#10546) Validate the error code of pipeline creation in order to return the status conflict when the error represents AlreadyExists. Signed-off-by: champon1020 <[email protected]>
… duplicate pipeline [Fixes kubeflow#10311] (kubeflow#10546) Validate the error code of pipeline creation in order to return the status conflict when the error represents AlreadyExists. Signed-off-by: champon1020 <[email protected]>
Description of your changes:
This is the backend fix of #10311.
I propose following solution but feel free to recommend a better one.
When uploading pipeline which already exists, it returns HTTP 500 error (internal server error) while it should return 409 error (conflict error). In order to solve this problem, I insert a branch by error code using
util.IsUserErrorCodeMatch
.Checklist: