-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backend + SDK): Add backend and SDK support to use Kubernetes FieldPath as env #10496
Conversation
Signed-off-by: Tommy Li <[email protected]>
/assign @connor-mccarthy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @chensun, I fixed the PR conflicts and it's good to go now. |
/retest |
Hi @rimolive, could you help review this PR and leave a lgtm. I have rebased this PR and is good to go, just need someone to double check and lgtm. |
/lgtm |
@Tomcli: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
…eldPath as env (kubeflow#10496) Signed-off-by: Tommy Li <[email protected]>
…eldPath as env (kubeflow#10496) Signed-off-by: Tommy Li <[email protected]>
Description of your changes:
fixes #10155
Add backend and SDK support to use Kubernetes FieldPath as env. This follows the Kubernetes document is set field as env variables. https://kubernetes.io/docs/tasks/inject-data-application/environment-variable-expose-pod-information/
This feature enables users to get information about the running pod such as metadata labels/annotations without gaining extra permission.
Checklist: