-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kubernetes_platform): Add k8s FieldPath as env to the kubernetes_platform #10485
Conversation
Signed-off-by: Tommy Li <[email protected]>
329585d
to
47a79f4
Compare
/assign @connor-mccarthy |
@Tomcli: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…_platform (kubeflow#10485) Signed-off-by: Tommy Li <[email protected]>
…_platform (kubeflow#10485) Signed-off-by: Tommy Li <[email protected]>
…_platform (kubeflow#10485) Signed-off-by: Tommy Li <[email protected]>
Description of your changes:
Part of #10155
Add new kubernetes_platform spec to set env from the metadata values and also the pod field values. The FieldPath value will always be a string based on the k8s documentation: https://kubernetes.io/docs/tasks/inject-data-application/environment-variable-expose-pod-information/
Checklist: