Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): fix string quotes #10413

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

connor-mccarthy
Copy link
Member

Description of your changes:
Fix string quotes to pass formatting presubmit.

Checklist:

Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@connor-mccarthy
Copy link
Member Author

/assign @rickyxie0929

@rickyxie0929
Copy link
Contributor

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jan 19, 2024
@connor-mccarthy
Copy link
Member Author

/retest
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: connor-mccarthy, rickyxie0929

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@connor-mccarthy
Copy link
Member Author

/retest

Copy link

@connor-mccarthy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-sdk-execution-tests ea9a0d7 link true /test kubeflow-pipelines-sdk-execution-tests
kfp-kubernetes-execution-tests ea9a0d7 link false /test kfp-kubernetes-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@connor-mccarthy
Copy link
Member Author

Manually merging. Failures are unrelated.

@connor-mccarthy connor-mccarthy merged commit 5b7f67a into kubeflow:master Jan 22, 2024
25 of 28 checks passed
roytman pushed a commit to roytman/pipelines that referenced this pull request Feb 14, 2024
stijntratsaertit pushed a commit to stijntratsaertit/kfp that referenced this pull request Feb 16, 2024
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 27, 2024
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants