Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): MLMD pagination on getting executions of DAG #10396

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

hellojunha
Copy link
Contributor

@hellojunha hellojunha commented Jan 15, 2024

Description of your changes:
Fixing issue 9878. Because default implementation of MLMD fetches 20 executions in one request, when there is over 20 executions in single DAG tasks could fail.
This change fetches next page automatically if NextPageToken exists so there is no missing execution.

Checklist:

Copy link

google-cla bot commented Jan 15, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

Hi @hellojunha. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chensun chensun self-requested a review January 18, 2024 23:32
@chensun chensun assigned chensun and zijianjoy and unassigned chensun Jan 18, 2024
@chensun chensun removed request for chensun and gkcalat January 18, 2024 23:33
@chensun
Copy link
Member

chensun commented Jan 18, 2024

/ok-to-test

Copy link

@hellojunha: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-samples-v2 34f2aba link false /test kubeflow-pipelines-samples-v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zijianjoy
Copy link
Collaborator

/lgtm
/approve

Thank you for the contribution!

@google-oss-prow google-oss-prow bot added the lgtm label Jan 24, 2024
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit f65bb0f into kubeflow:master Jan 24, 2024
5 of 6 checks passed
roytman pushed a commit to roytman/pipelines that referenced this pull request Feb 14, 2024
stijntratsaertit pushed a commit to stijntratsaertit/kfp that referenced this pull request Feb 16, 2024
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 27, 2024
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants