Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components) Extend kserve component #10136

Merged
merged 5 commits into from
Oct 23, 2023
Merged

feat(components) Extend kserve component #10136

merged 5 commits into from
Oct 23, 2023

Conversation

magdalenakuhn17
Copy link
Contributor

@magdalenakuhn17 magdalenakuhn17 commented Oct 22, 2023 •
edited
Loading

Description of your changes:

  • Extending kserve component predictor to use a fixed runtime version and specific resource requests/limits
  • Verified, that all frameworks listed here expose resources and runtime_version

Checklist:

@google-oss-prow google-oss-prow bot requested review from Tomcli and yhwang October 22, 2023 17:03
@google-oss-prow
Copy link

Hi @magdalenakuhn17. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Tomcli
Copy link
Member

Tomcli commented Oct 23, 2023

/ok-to-test

Tomcli
Tomcli suggested changes Oct 23, 2023
View reviewed changes
Copy link
Member

@Tomcli Tomcli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions on incorrect import package and json loads formats.

components/kserve/src/kservedeployer.py Outdated Show resolved Hide resolved
components/kserve/src/kservedeployer.py Outdated Show resolved Hide resolved
components/kserve/src/kservedeployer.py Outdated Show resolved Hide resolved
Tomcli
Tomcli approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@Tomcli Tomcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks @magdalenakuhn17 for your contribution

@google-oss-prow google-oss-prow bot added the lgtm label Oct 23, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tomcli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 2054b7c into kubeflow:master Oct 23, 2023
1 check passed
stijntratsaertit pushed a commit to stijntratsaertit/kfp that referenced this pull request Feb 16, 2024
@magdalenakuhn17 @Tomcli @stijntratsaertit
feat(components) Extend kserve component (kubeflow#10136)
518affe 
* add runtime version, resource requests and resource limits

* adjust kservedeployer

* Update components/kserve/src/kservedeployer.py

Co-authored-by: Tommy Li <[email protected]>

* Update components/kserve/src/kservedeployer.py

Co-authored-by: Tommy Li <[email protected]>

* Update components/kserve/src/kservedeployer.py

Co-authored-by: Tommy Li <[email protected]>

---------

Co-authored-by: Tommy Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomcli Tomcli Tomcli approved these changes

@yhwang yhwang Awaiting requested review from yhwang

Assignees

@Tomcli Tomcli

Labels
approved lgtm ok-to-test size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magdalenakuhn17 @Tomcli