Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test coverage for runs without experiments #685

Closed
IronPan opened this issue Jan 15, 2019 · 3 comments
Closed

Test coverage for runs without experiments #685

IronPan opened this issue Jan 15, 2019 · 3 comments
Assignees
@rileyjbauer
Labels
area/backend kind/bug priority/p0

Comments

@IronPan
Copy link
Member

IronPan commented Jan 15, 2019 •
edited
Loading

Since we enabled runs without experiments at API level, we need proper test coverages for runs without experiments, e.g. unit tests, e2e tests.
@IronPan
Copy link
Member Author

IronPan commented Mar 27, 2019 •
edited
Loading

@rileyjbauer could you help verify we can still create runs without experiment? I suggest we don't enable this functionality if it's not being used, or easy to disable in frontend. instead I think we should create a default experiment and use that in case people want to skip creating one.

@IronPan IronPan assigned rileyjbauer and unassigned IronPan Mar 27, 2019
@rileyjbauer
Copy link
Contributor

Yes, it is still very easy to create runs without experiments via the UI. A user can simply hit + Create run from a Pipeline's page, and then not choose an experiment, and the run will not be associated with any experiment.

@rileyjbauer
Copy link
Contributor

This issue should be obsolete with #1089 which places all runs created without an explicit experiment into a "Default" experiment

Linchin pushed a commit to Linchin/pipelines that referenced this issue Apr 11, 2023
@jlewi
Fix a bug in tekton_client.py (kubeflow#686)
e72b7f5 
* The CLI code isn't actually doing anything when invoked with "junit-and-upload". This was a bug introduced by kubeflow#683

Related to kubeflow#685
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this issue Mar 11, 2024
@yhwang
remove ContainerOp from test cases - part 1 (kubeflow#685)
d463f16 
eliminate the usage of ContainerOp in testcases and
update the testcase accordingly.

Signed-off-by: Yihong Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rileyjbauer rileyjbauer

Labels
area/backend kind/bug priority/p0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@IronPan @vicaire @rileyjbauer