We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After #5266, I noticed in tests, the warning
Cannot validate the compiled workflow. Found the argo program in PATH, but it's not usable. argo v2.4.3 should work.
KFP SDK can use latest argo CLI to validate workflows locally.
KFP SDK version: 1.4.0
[Miscellaneous information that will assist in solving the issue.]
/kind bug
/area sdk
The root cause seems to be that, KFP SDK tries to lint empty input using argo CLI to verify if argo CLI works.
However, the default behavior of Argo CLI changed, it gives an error when validating empty string.
We should update to validate an empty workflow instead.
See
pipelines/sdk/python/kfp/compiler/compiler.py
Line 1094 in 21e3ef8
The text was updated successfully, but these errors were encountered:
/assign @Ark-kun @chensun
Sorry, something went wrong.
fix(sdk): make workflow validation compatible with argo CLI v2.12+. F…
8a32632
…ixes #4775, Fixes #5296 (#4804) * updated the validation default test * updated the version * Update compiler.py * Update compiler.py * Update compiler.py Co-authored-by: Yuan (Bob) Gong <[email protected]>
Ark-kun
chensun
Successfully merging a pull request may close this issue.
What happened:
After #5266, I noticed in tests, the warning
What did you expect to happen:
KFP SDK can use latest argo CLI to validate workflows locally.
Environment:
KFP SDK version: 1.4.0
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
/kind bug
/area sdk
The root cause seems to be that, KFP SDK tries to lint empty input using argo CLI to verify if argo CLI works.
However, the default behavior of Argo CLI changed, it gives an error when validating empty string.
We should update to validate an empty workflow instead.
See
pipelines/sdk/python/kfp/compiler/compiler.py
Line 1094 in 21e3ef8
The text was updated successfully, but these errors were encountered: