Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk] KFP SDK fail to use argo CLI >=2.12 to lint workflows #5296

Closed
Bobgy opened this issue Mar 13, 2021 · 1 comment · Fixed by #4804
Closed

[sdk] KFP SDK fail to use argo CLI >=2.12 to lint workflows #5296

Bobgy opened this issue Mar 13, 2021 · 1 comment · Fixed by #4804
Assignees
Labels

Comments

@Bobgy
Copy link
Contributor

Bobgy commented Mar 13, 2021

What happened:

After #5266, I noticed in tests, the warning

Cannot validate the compiled workflow. Found the argo program in PATH, but it's not usable. argo v2.4.3 should work.

What did you expect to happen:

KFP SDK can use latest argo CLI to validate workflows locally.

Environment:

KFP SDK version: 1.4.0

Anything else you would like to add:

[Miscellaneous information that will assist in solving the issue.]

/kind bug

/area sdk

The root cause seems to be that, KFP SDK tries to lint empty input using argo CLI to verify if argo CLI works.

However, the default behavior of Argo CLI changed, it gives an error when validating empty string.

We should update to validate an empty workflow instead.

See

has_working_argo_lint = _run_argo_lint('')

@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 13, 2021

/assign @Ark-kun @chensun

google-oss-robot pushed a commit that referenced this issue Mar 19, 2021
…ixes #4775, Fixes #5296 (#4804)

* updated the validation default test

* updated the version

* Update compiler.py

* Update compiler.py

* Update compiler.py

Co-authored-by: Yuan (Bob) Gong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants