Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] TTL_SECONDS_AFTER_WORKFLOW_FINISH #3938

Closed
Bobgy opened this issue Jun 9, 2020 · 12 comments
Closed

[Documentation] TTL_SECONDS_AFTER_WORKFLOW_FINISH #3938

Bobgy opened this issue Jun 9, 2020 · 12 comments
Assignees
Labels
area/docs help wanted The community is welcome to contribute. kind/misc types beside feature and bug lifecycle/frozen priority/p2 status/triaged Whether the issue has been explicitly triaged

Comments

@Bobgy
Copy link
Contributor

Bobgy commented Jun 9, 2020

ENV TTL_SECONDS_AFTER_WORKFLOW_FINISH 604800

the env var works for deployment ml-pipeline-persistenceagent
It deletes workflow resources after it is completed and reaches a TTL

@Bobgy Bobgy added area/docs kind/misc types beside feature and bug labels Jun 9, 2020
@Bobgy Bobgy added priority/p0 status/triaged Whether the issue has been explicitly triaged labels Jun 9, 2020
@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 9, 2020

There should be documentation how this should be configured and in which situations.

@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 9, 2020

@jingzhang36
Copy link
Contributor

jingzhang36 commented Jun 11, 2020

Let me try to see if we can have multiple controlling factors here. For example, if workflow controller detects either a certain number of workflows have been reached, or the workflow is older than ttl, the controller can gc the oldest workflow. In other words, ttl is the maximum time of a workflow, which can gc'ed earlier if the other constraint (workflow count upper limit) is reached.

@Bobgy Bobgy added the help wanted The community is welcome to contribute. label Jun 30, 2020
@stale

This comment has been minimized.

@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Sep 28, 2020
@Bobgy

This comment has been minimized.

@stale

This comment has been minimized.

@stale stale bot closed this as completed Oct 7, 2020
@Bobgy

This comment has been minimized.

@k8s-ci-robot

This comment has been minimized.

@k8s-ci-robot k8s-ci-robot reopened this Oct 13, 2020
@stale stale bot removed the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Oct 13, 2020
@stale

This comment has been minimized.

@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Jan 11, 2021
@Bobgy
Copy link
Contributor Author

Bobgy commented Jan 29, 2021

/lifecycle frozen

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Oct 31, 2024

/close

Because it seems to be working

Copy link

@juliusvonkohout: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs help wanted The community is welcome to contribute. kind/misc types beside feature and bug lifecycle/frozen priority/p2 status/triaged Whether the issue has been explicitly triaged
Projects
None yet
Development

No branches or pull requests

4 participants