URLs in Artifact viewer do not display underscores right "_"

[paveldournov]

In the artifact pane the URLs shown for Metadata artifacts do not display underscores and instead turn the text to italic. When the user copies the URL - it gets copied without the underscores and thus does not point to a valid file.

[numerology]

/assign @numerology

[numerology]

The culprit is that underscore is not properly escaped when TFX image writing the markdown string

See [1]

[1] https://github.com/tensorflow/tfx/blob/master/tfx/orchestration/kubeflow/container_entrypoint.py#L218

[Bobgy]

There may be other formatting conflicts later, I think instead of escaping, we should wrap data with ``

[rmgogogo]

if quick fix, we may put it to OSS 1.0

[Bobgy]

I'm leaning avoid escaping underscore in UI, adding hack on top of a proper markdown parser is fragile.

e.g. how do we not escape underscores that are already escaped? how many other corner cases there are?

[Bobgy]

I think the best fix is to render execution detail page as a tab and let tfx side remove the markdown. Execution detail page has all the information in the best accessible form.

[numerology]

I think the best fix is to render execution detail page as a tab and let tfx side remove the markdown. Execution detail page has all the information in the best accessible form.

Sounds good. Anyway I'm quickly fix it by escaping underscore in the entrypoint.

[Bobgy]

@numerology did you fix the issue? With #3457 we may also remove the markdown. (but we can keep it for a while before people can upgrade KFP installation).

[numerology]

@numerology did you fix the issue? With #3457 we may also remove the markdown. (but we can keep it for a while before people can upgrade KFP installation).

It should be fixed in tensorflow/tfx@3ea79f9

[Bobgy]

@numerology thanks!
let's close this then
/close

[k8s-ci-robot]

@Bobgy: Closing this issue.

In response to this:

@numerology thanks!
let's close this then
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.