Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Pagination for artifact and execution list pages #3226

Closed
Bobgy opened this issue Mar 6, 2020 · 14 comments
Closed

[UI] Pagination for artifact and execution list pages #3226

Bobgy opened this issue Mar 6, 2020 · 14 comments

Comments

@Bobgy
Copy link
Contributor

Bobgy commented Mar 6, 2020

Both pages show all content from server in one page.
Without server side pagination, this will be a blocker for frequent usages.

/cc @neuromage
Do you know if MLMD server supports pagination?

/area frontend
/area backend
/kind feature

@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 6, 2020

/assign @Bobgy

@Bobgy Bobgy modified the milestone: kfp Mar 6, 2020
@kubeflow kubeflow deleted a comment from k8s-ci-robot Mar 6, 2020
@Bobgy Bobgy self-assigned this Mar 6, 2020
@Bobgy Bobgy added status/triaged Whether the issue has been explicitly triaged priority/p1 labels Mar 6, 2020
@neuromage
Copy link
Contributor

Both pages show all content from server in one page.
Without server side pagination, this will be a blocker for frequent usages.

/cc @neuromage
Do you know if MLMD server supports pagination?

It does not. There's another internal bug discussing the need for this, I'll cc you on that one.

/cc @hughmiao

@numerology
Copy link

+1. Pagination helps the scalability of MLMD as well.

@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 12, 2020

Bumping priority because there are more feedback this is highly needed for scalable usage of the UI.
I can start working on this once the backend and db layer supports pagination.

@Bobgy
Copy link
Contributor Author

Bobgy commented Apr 7, 2020

Dropping priority, because I think #3457 will be a better way for navigating MLMD data. We can leverage existing KFP UI for pagination, sorting and filtering support.

@stale
Copy link

stale bot commented Jul 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Jul 6, 2020
@Bobgy
Copy link
Contributor Author

Bobgy commented Jul 6, 2020

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen and removed lifecycle/stale The issue / pull request is stale, any activities remove this label. labels Jul 6, 2020
@Bobgy Bobgy assigned zijianjoy and unassigned Bobgy May 18, 2021
@Bobgy Bobgy added size/L and removed area/backend kind/feature priority/p1 status/triaged Whether the issue has been explicitly triaged labels May 24, 2021
@jli
Copy link
Contributor

jli commented Oct 30, 2021

just FYI: I noticed that the "Artifacts" and "Executions" pages are slow on my KFP 1.5.1 cluster. The /ml_metadata.MetadataStoreService/GetExecutions and /ml_metadata.MetadataStoreService/GetArtifacts endpoints both return >200MB of data:

Screen Shot 2021-10-30 at 14 48 55

It also seems like the Artifacts page then launches a GetEventByArtifactIDs request for each artifact concurrently, resulting in the browser using 100% CPU to send a huge number of requests, and the tab becoming unresponsive:
Screen Shot 2021-10-30 at 15 04 52

My team doesn't use the Artifacts or Executions pages, so this isn't a huge issue for us, but just sharing that these pages seem to become unusable for teams with a large number of runs.

@djwhatle
Copy link

I'm seeing every load of the artifacts page fail, seemingly due to the large number of requests (thousands) fired off all at once.

index.js:38 POST /ml_metadata.MetadataStoreService/GetEventsByArtifactIDs net::ERR_INSUFFICIENT_RESOURCES

Any update on current thoughts on how to improve this situation @Bobgy? Wondering if maintainers are leaning towards deprecating the artifacts page in favor of the run details page per #3457, or if pagination of artifacts is still on the roadmap?

@zijianjoy
Copy link
Collaborator

@djwhatle Pagination is on our roadmap to allow for better performance on Artifact page. We don't currently plan to deprecate this page. Artifact page is the entry for MLMD Lineage graph.

@thesuperzapper
Copy link
Member

thesuperzapper commented Dec 20, 2021

@zijianjoy, the current "Artifacts" page really is not acceptable, it is creating an unbelievable number of requests, we either need to remove this page, or prevent it from flooding the user's cluster with requests.

EDIT: I think the quickest "fix" is to limit the number of artifacts returned, at least until we can add pagination.

@Bobgy
Copy link
Contributor Author

Bobgy commented Dec 20, 2021

+1, before the page is in a usable state, maybe it's better to hide it first?

@rimolive
Copy link
Member

rimolive commented Apr 9, 2024

Pagination was implemented in latest versions. Closing this issue.

/close

Copy link

@rimolive: Closing this issue.

In response to this:

Pagination was implemented in latest versions. Closing this issue.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants