Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Server Testing - test infra for pipeline ui node server #2215

Closed
3 of 4 tasks
Bobgy opened this issue Sep 24, 2019 · 7 comments · Fixed by #3304
Closed
3 of 4 tasks

[Frontend] Server Testing - test infra for pipeline ui node server #2215

Bobgy opened this issue Sep 24, 2019 · 7 comments · Fixed by #3304

Comments

@Bobgy
Copy link
Contributor

Bobgy commented Sep 24, 2019

Pipeline UI node server has 0 test coverage at the moment. It prevents adding new features into the node server with confidence. In order to test more nuanced features like added in #2081.

We should add

  • (lower effort, lower confidence) some basic jest tests that just test the node server
  • (higher effort, higher confidence) some e2e tests that test the node server with a real cluster

Starting with jest tests would be the best

Work Items:

/priority p0
/area testing

@Ark-kun
Copy link
Contributor

Ark-kun commented Sep 25, 2019

Can you clarify the e2e tests item? I think we run some frontend tests as part of 2e2 tests.

@Bobgy
Copy link
Contributor Author

Bobgy commented Sep 27, 2019

I saw there are some UI e2e tests, but I don't think they cover all usages of the node server.
I need to look deeper for a list of things it didn't cover.

@Bobgy Bobgy changed the title Frontend Server Testing - test infra for pipeline ui node server [Frontend] Server Testing - test infra for pipeline ui node server Oct 23, 2019
@Bobgy Bobgy removed the priority/p1 label Nov 6, 2019
@rmgogogo rmgogogo added the kind/misc types beside feature and bug label Nov 18, 2019
@Bobgy
Copy link
Contributor Author

Bobgy commented Dec 17, 2019

Thanks to @eterna2, #2745 will be the first step.

@Bobgy
Copy link
Contributor Author

Bobgy commented Jan 20, 2020

All p0 issues resolved

@Bobgy Bobgy added status/triaged Whether the issue has been explicitly triaged area/engprod and removed kind/misc types beside feature and bug priority/p0 labels Jan 22, 2020
@Bobgy
Copy link
Contributor Author

Bobgy commented Jan 22, 2020

/priority p1

@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 19, 2020

The last p2 item of Unit tests for low coverage files according to coverage report can be improved in a separate issue. This one can be considered done.

/close

@k8s-ci-robot
Copy link
Contributor

@Bobgy: Closing this issue.

In response to this:

The last p2 item of Unit tests for low coverage files according to coverage report can be improved in a separate issue. This one can be considered done.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants