Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible inconsistent experiment name in sample test. #2110

Closed
numerology opened this issue Sep 13, 2019 · 2 comments
Closed

Possible inconsistent experiment name in sample test. #2110

numerology opened this issue Sep 13, 2019 · 2 comments
Assignees
@numerology
Labels
area/samples/notebooks area/testing priority/p0

Comments

@numerology
Copy link

Currently, it is possible for a user to upload a notebook sample with hard-coded arbitrary experiment name to run their pipeline. However, our sample test infra adopts the convention that the experiment name should be TEST_NAME-test, which might be inconsistent with the user specified name.

Inconsistent names can cause the sample test infra fails to capture the test run result.
@numerology numerology self-assigned this Sep 13, 2019
@numerology numerology mentioned this issue Sep 13, 2019
Merged
@numerology
Copy link
Author

/close
Fixed by #2292 .
Now sample test infra can override experiment name through env var.

@k8s-ci-robot
Copy link
Contributor

@numerology: Closing this issue.

In response to this:

/close
Fixed by #2292 .
Now sample test infra can override experiment name through env var.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
@markwinter
Move ComponentExtensionSpec validation to own test file (kubeflow#2110)
ffa250a 
* remove incorrect and duplicated tests

Signed-off-by: Mark Winter <[email protected]>

* add component validation test

Signed-off-by: Mark Winter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@numerology numerology

Labels
area/samples/notebooks area/testing priority/p0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@numerology @k8s-ci-robot