Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler should stop auto-adding artifacts to every op unless they're explicitly specified #1422

Closed
Ark-kun opened this issue Jun 1, 2019 · 1 comment · Fixed by #2046
Closed

Compiler should stop auto-adding artifacts to every op unless they're explicitly specified #1422

Ark-kun opened this issue Jun 1, 2019 · 1 comment · Fixed by #2046
Assignees
@kevinbache @Ark-kun @gaoning777
Labels
area/sdk/dsl/compiler kind/feature priority/p1

Comments

@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 1, 2019

Requires #1421
@Ark-kun Ark-kun self-assigned this Jun 1, 2019
@Ark-kun Ark-kun mentioned this issue Jun 1, 2019
Closed
@Ark-kun Ark-kun mentioned this issue Jul 26, 2019
Closed
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jul 29, 2019 •
edited
Loading

Here is an example of the problem caused by this issue: #1654

Ark-kun added a commit to Ark-kun/pipelines that referenced this issue Sep 5, 2019
@Ark-kun
SDK - DSL - Stopped adding mlpipeline artifacts to every compiled tem…
bdd43a5 
…plate

Fixes kubeflow#1421
Fixes kubeflow#1422
@Ark-kun Ark-kun mentioned this issue Sep 5, 2019
Merged
k8s-ci-robot pushed a commit that referenced this issue Sep 6, 2019
@Ark-kun @k8s-ci-robot
SDK - Compiler - Stopped adding mlpipeline artifacts to every compile…
5360f3f 
…d template (#2046)

* Explicitly added mlpipeline outputs to the components that actually produce them

* Updated samples

* SDK - DSL - Stopped adding mlpipeline artifacts to every compiled template
Fixes #1421
Fixes #1422

* Updated the Lighweight sample

* Updated the compiler tests

* Fixed the lightweight sample

* Reverted the change to one contrib/samples/openvino
The sample will still work fine as it is now.
I'll add the change to that file as a separate PR.
@Ark-kun Ark-kun mentioned this issue Oct 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinbache kevinbache

@Ark-kun Ark-kun

@gaoning777 gaoning777

Labels
area/sdk/dsl/compiler kind/feature priority/p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SDK - Compiler - Stopped adding mlpipeline artifacts to every compiled template Ark-kun/pipelines
3 participants
@kevinbache @Ark-kun @gaoning777