Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sdk/python/setup.py use requirements.txt #1271

Closed
Ark-kun opened this issue May 1, 2019 · 4 comments
Closed

Make sdk/python/setup.py use requirements.txt #1271

Ark-kun opened this issue May 1, 2019 · 4 comments
Assignees
@Ark-kun
Labels
area/sdk kind/feature priority/p2

Comments

@Ark-kun
Copy link
Contributor

Ark-kun commented May 1, 2019 •
edited
Loading

Currently we have two places in SDK where the list of dependencies is specified - setup.py and requirements.txt. There should be a single list so that there is a single source of truth.

It's a bit non-trivial. It might sound strange, but there is no built-in requirements.txt parser and also setup does not have full support by design.

The position of the python devs is that setup.py requirements and requirements.txt serve different purposes and they do not want to fully support intermixing them.
@Ark-kun Ark-kun self-assigned this May 1, 2019
@Ark-kun Ark-kun mentioned this issue May 1, 2019
Merged
@gaoning777 gaoning777 changed the title Make setup.py use requirements.txt Make sdk/python/setup.py use requirements.txt May 1, 2019
@vicaire
Copy link
Contributor

vicaire commented May 31, 2019

@Ark-kun, could you please provide more details about why this needs to be done? Thanks!

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 1, 2019

@Ark-kun, could you please provide more details about why this needs to be done? Thanks!

Done.

@gaoning777
Copy link
Contributor

/unassign @gaoning777

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Feb 18, 2020

The position of the python devs is that setup.py requirements and requirements.txt serve different purposes and they do not want to fully support intermixing them.

setup.py will continue to have a flexible list of directly required packaged while requirements.txt should serve as a known-good configuration that can be used for image building and should be periodically upgraded.

@Ark-kun Ark-kun closed this as completed Feb 18, 2020
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
@yuzisun
Update torchserve docs (kubeflow#1271)
1ca8977 
* Update torchserve doc

* Fix autoscaling/canary example

* Reorgnize torchserve examples

* Add bert example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ark-kun Ark-kun

Labels
area/sdk kind/feature priority/p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevinbache @Ark-kun @gaoning777 @vicaire