Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watson sample errors and inconsistencies #1254

Closed
mpoqq opened this issue Apr 28, 2019 · 3 comments
Closed

Watson sample errors and inconsistencies #1254

mpoqq opened this issue Apr 28, 2019 · 3 comments

Comments

@mpoqq
Copy link
Contributor

mpoqq commented Apr 28, 2019

While going through the watson example I noticed the following errors:

  1. The Kubernetes serviceaccount pipeline-runner has no rights to create secrets (affected line).
  2. All labels in the component.yaml are not allowed values (IBM Watson Machine Learning). Space characters are not allowed.
  3. wml-train.py needs the cos_endpoint in two different formats. Minio needs the endpoint without scheme (https://) and the model metadata connection endpoints (line) needs the endpoint with scheme. More specific error occurs at the attempt to monitor the training run (line)
  4. Due to assumption that the input parameter is created in wm-train.py, the sample will not work any more. The output of the config step will not return "created". Additional is the order of the input parameter in the train step is incorrect.

Locally I was able to fix all of this bugs. If I should create a pull request let me know.
@animeshsingh and @Ark-kun I think this issue is interesting for you.

@animeshsingh
Copy link
Contributor

@mpoqq there is PR pending merge 2, 4, and in our deployments by default we give increased permissions to pipeline runner. Once that PR is merged will be good to get to get yours on top
#1246

@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 5, 2019

@animeshsingh @mpoqq Is this issue still relevant?

@mpoqq
Copy link
Contributor Author

mpoqq commented Jun 5, 2019

No, sorry. The bugs are fixed.

@mpoqq mpoqq closed this as completed Jun 5, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
* Create grpc_predict_v2.proto

* Link to local proto file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants