Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit handler task does not have proper name in the UX #1051

Closed
Ark-kun opened this issue Mar 27, 2019 · 5 comments
Closed

Exit handler task does not have proper name in the UX #1051

Ark-kun opened this issue Mar 27, 2019 · 5 comments

Comments

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 27, 2019

image

The task should be shown as something like: "Exit handler: Delete cluster".

@vicaire
Copy link
Contributor

vicaire commented Mar 27, 2019

Looks like a duplicate of #78

@vicaire vicaire closed this as completed Mar 27, 2019
@rileyjbauer
Copy link
Contributor

I think this is different. #78 is more about the output of the DSL and the interface between that output and the frontend. This is more just a question of if we can come up with a friendlier name for these nodes, which I believe we can, something like onExit - TEMPLATE_NAME

@ajayalfred we style exit handler nodes in the static graph like this:
image

Should we similarly color that node in the runtime graph like so? (note that hovering over the node will display the untruncated name as a tooltip)
image

Alternatively, we can leave it white:
image

@vicaire
Copy link
Contributor

vicaire commented Mar 27, 2019

Thanks for the clarification @rileyjbauer.

@ajayalfred
Copy link
Contributor

I think the standard node treatment (white container) for the exit handlers is fine. Grey on grey doesn't provide enough contrast.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Mar 27, 2019

On one hand, I like the the standard treatment (the last image).
On another hand, I'm worrying about drawing connections with every other node is going to overcomplicate the graph if the graph has many nodes.

HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this issue Mar 11, 2024
Add a test to verify the performance of webhook
validation. huge amount of edges in DAG causes
a performance issue in tekton earlier. adding
this test case to avoid the performance degradation.

Signed-off-by: Yihong Wang <[email protected]>

Signed-off-by: Yihong Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants