-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exit handler task does not have proper name in the UX #1051
Comments
Looks like a duplicate of #78 |
I think this is different. #78 is more about the output of the DSL and the interface between that output and the frontend. This is more just a question of if we can come up with a friendlier name for these nodes, which I believe we can, something like @ajayalfred we style exit handler nodes in the static graph like this: Should we similarly color that node in the runtime graph like so? (note that hovering over the node will display the untruncated name as a tooltip) |
Thanks for the clarification @rileyjbauer. |
I think the standard node treatment (white container) for the exit handlers is fine. Grey on grey doesn't provide enough contrast. |
On one hand, I like the the standard treatment (the last image). |
Add a test to verify the performance of webhook validation. huge amount of edges in DAG causes a performance issue in tekton earlier. adding this test case to avoid the performance degradation. Signed-off-by: Yihong Wang <[email protected]> Signed-off-by: Yihong Wang <[email protected]>
The task should be shown as something like: "Exit handler: Delete cluster".
The text was updated successfully, but these errors were encountered: