Skip to content

Commit

Permalink
Components - Fixed BugQuery - Query component (#3514)
Browse files Browse the repository at this point in the history
Working around an Argo bug.
Revert this when we upgrade to Argo version which has the fix: argoproj/argo-workflows#1653
  • Loading branch information
Ark-kun authored Apr 17, 2020
1 parent 08c7c0e commit f3b1d6f
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,10 @@ def _dump_outputs(job, output_path, table_ref):
gcp_common.dump_file(KFP_OUTPUT_PATH + 'bigquery/query-job.json',
json.dumps(job.to_api_repr()))
if not output_path:
output_path = ''
output_path = '-' # Replace with empty string when we upgrade to Argo version which has the fix: https://github.com/argoproj/argo/pull/1653
gcp_common.dump_file(KFP_OUTPUT_PATH + 'bigquery/query-output-path.txt',
output_path)
(dataset_id, table_id) = (table_ref.dataset_id, table_ref.table_id) if table_ref else ('', '')
(dataset_id, table_id) = (table_ref.dataset_id, table_ref.table_id) if table_ref else ('-', '-')
gcp_common.dump_file(KFP_OUTPUT_PATH + 'bigquery/query-dataset-id.txt',
dataset_id)
gcp_common.dump_file(KFP_OUTPUT_PATH + 'bigquery/query-table-id.txt',
Expand Down

1 comment on commit f3b1d6f

@rmgogogo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bugquery => bigquery ? :-)
Thought we provide some fancy feature

Please sign in to comment.