Skip to content

Commit

Permalink
feat(deployment): Add env/platform-agnostic-pns standalone deployment…
Browse files Browse the repository at this point in the history
… option (#4278)

Add containerRuntimeExecutor explicit type on the configMap
configuration. Set `docker` as default.
Add platform-agnostic type configuration needed by Kind, K3s and
Minikube.
Part of #4256
  • Loading branch information
Gsantomaggio authored and Bobgy committed Aug 12, 2020
1 parent 8e4d305 commit ee11f9e
Show file tree
Hide file tree
Showing 5 changed files with 37 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ data:
{
namespace: $(kfp-namespace),
executorImage: gcr.io/ml-pipeline/argoexec:v2.7.5-license-compliance,
containerRuntimeExecutor: $(kfp-container-runtime-executor),
artifactRepository:
{
s3: {
Expand Down
7 changes: 7 additions & 0 deletions manifests/kustomize/base/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,5 +46,12 @@ vars:
apiVersion: v1
fieldref:
fieldpath: data.bucketName
- name: kfp-container-runtime-executor
objref:
kind: ConfigMap
name: pipeline-install-config
apiVersion: v1
fieldref:
fieldpath: data.containerRuntimeExecutor
configurations:
- params.yaml
7 changes: 7 additions & 0 deletions manifests/kustomize/base/params.env
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,10 @@ mlmdDb=metadb
cacheDb=cachedb
pipelineDb=mlpipeline
bucketName=mlpipeline


## containerRuntimeExecutor: A workflow executor is a process
## that allows Argo to perform certain actions like monitoring pod logs,
## artifacts, container lifecycles, etc..
## Doc: https://github.com/argoproj/argo/blob/master/docs/workflow-executors.md
containerRuntimeExecutor=docker
21 changes: 21 additions & 0 deletions manifests/kustomize/env/platform-agnostic-pns/kustomization.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

bases:
- ../platform-agnostic

# Identifier for application manager to apply ownerReference.
# The ownerReference ensures the resources get garbage collected
# when application is deleted.
commonLabels:
application-crd-id: kubeflow-pipelines

# !!! If you want to customize the namespace,
# please refer sample/cluster-scoped-resources to update the namespace for cluster-scoped-resources
namespace: kubeflow

# Used by Kustomize
configMapGenerator:
- name: pipeline-install-config
env: params.env
behavior: merge
1 change: 1 addition & 0 deletions manifests/kustomize/env/platform-agnostic-pns/params.env
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
containerRuntimeExecutor=pns

0 comments on commit ee11f9e

Please sign in to comment.