[Viewer] Service needs port name for istio (#3619)

kubeflow · Apr 27, 2020 · de0747e · de0747e
1 parent a94597f
commit de0747e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/backend/src/crd/controller/viewer/reconciler/reconciler.go b/backend/src/crd/controller/viewer/reconciler/reconciler.go
@@ -260,6 +260,7 @@ func serviceFrom(v *viewerV1beta1.Viewer, deploymentName string) *corev1.Service
 			},
 			Ports: []corev1.ServicePort{
 				corev1.ServicePort{
+					Name:       "http",
 					Protocol:   corev1.ProtocolTCP,
 					Port:       80,
 					TargetPort: intstr.IntOrString{IntVal: viewerTargetPort}},

diff --git a/backend/src/crd/controller/viewer/reconciler/reconciler_test.go b/backend/src/crd/controller/viewer/reconciler/reconciler_test.go
@@ -359,6 +359,7 @@ func TestReconcile_EachViewerCreatesAService(t *testing.T) {
 			}},
 		Spec: corev1.ServiceSpec{
 			Ports: []corev1.ServicePort{corev1.ServicePort{
+				Name:       "http",
 				Protocol:   corev1.ProtocolTCP,
 				Port:       int32(80),
 				TargetPort: intstr.IntOrString{IntVal: viewerTargetPort},