Metadata: Adding metadata-grpc config map

This change adds the necessary config-map related to gRPC MLMD server. To make the names more clear, this change also modifies the existing 'metadata-configmap' which provides mysql configurations to 'metadata-mysql-configmap'
kubeflow · Dec 12, 2019 · a2e4246 · a2e4246
1 parent 0548e63
commit a2e4246
Show file tree

Hide file tree

Showing 3 changed files with 55 additions and 6 deletions.
diff --git a/manifests/gcp_marketplace/chart/kubeflow-pipelines/templates/metadata.yaml b/manifests/gcp_marketplace/chart/kubeflow-pipelines/templates/metadata.yaml
@@ -58,17 +58,17 @@ spec:
         - name: MYSQL_DATABASE
           valueFrom:
             configMapKeyRef:
-              name: metadata-configmap
+              name: metadata-mysql-configmap
               key: mysql_database
         - name: MYSQL_HOST
           valueFrom:
             configMapKeyRef:
-              name: metadata-configmap
+              name: metadata-mysql-configmap
               key: mysql_host
         - name: MYSQL_PORT
           valueFrom:
             configMapKeyRef:
-              name: metadata-configmap
+              name: metadata-mysql-configmap
               key: mysql_port
         command: ["/bin/metadata_store_server"]
         args: ["--grpc_port=8080",
@@ -140,3 +140,30 @@ data:
   mysql_port: "3306"
   username: "root"
   password: ""
+---
+apiVersion: v1
+kind: ConfigMap
+metadata:
+  name: metadata-mysql-configmap
+  labels:
+    component: metadata-server
+data:
+  {{ if .Values.managedstorage.databaseNamePrefix }}
+  mysql_database: '{{ .Values.managedstorage.databaseNamePrefix }}_metadata'
+  {{ else }}
+  mysql_database: '{{ .Release.Name | replace "-" "_" | replace "." "_"}}_metadata'
+  {{ end }}
+  mysql_host: "mysql"
+  mysql_port: "3306"
+  username: "root"
+  password: ""
+---
+apiVersion: v1
+kind: ConfigMap
+metadata:
+  name: metadata-grpc-configmap
+  labels:
+    component: metadata-server
+data:
+  METADATA_GRPC_SERVICE_HOST: "metadata-service"
+  METADATA_GRPC_SERVICE_PORT: "8080"
diff --git a/manifests/kustomize/base/metadata/metadata-configmap.yaml b/manifests/kustomize/base/metadata/metadata-configmap.yaml
@@ -1,3 +1,4 @@
+# metadata-config is retained for backward compatibility reasons.
 apiVersion: v1
 kind: ConfigMap
 metadata:
@@ -8,3 +9,24 @@ data:
   mysql_database: "metadb"
   mysql_host: "mysql"
   mysql_port: "3306"
+---
+apiVersion: v1
+kind: ConfigMap
+metadata:
+  name: metadata-mysql-configmap
+  labels:
+    component: metadata-server
+data:
+  mysql_database: "metadb"
+  mysql_host: "mysql"
+  mysql_port: "3306"
+---
+apiVersion: v1
+kind: ConfigMap
+metadata:
+  name: metadata-grpc-configmap
+  labels:
+    component: metadata-server
+data:
+  METADATA_GRPC_SERVICE_HOST: "metadata-service"
+  METADATA_GRPC_SERVICE_PORT: "8080"
diff --git a/manifests/kustomize/base/metadata/metadata-deployment.yaml b/manifests/kustomize/base/metadata/metadata-deployment.yaml
@@ -31,17 +31,17 @@ spec:
         - name: MYSQL_DATABASE
           valueFrom:
             configMapKeyRef:
-              name: metadata-configmap
+              name: metadata-mysql-configmap
               key: mysql_database
         - name: MYSQL_HOST
           valueFrom:
             configMapKeyRef:
-              name: metadata-configmap
+              name: metadata-mysql-configmap
               key: mysql_host
         - name: MYSQL_PORT
           valueFrom:
             configMapKeyRef:
-              name: metadata-configmap
+              name: metadata-mysql-configmap
               key: mysql_port
         command: ["/bin/metadata_store_server"]
         args: ["--grpc_port=8080",