Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebooks 2.0 // Backend // Update list workspacekinds JSON payloads #128

Closed
ederign opened this issue Nov 18, 2024 · 5 comments
Closed
Assignees

Comments

@ederign
Copy link
Member

ederign commented Nov 18, 2024

Proposed payload:

{
  "name": "jupyterlab",
  "display_name": "JupyterLab Notebook",
  "description": "A Workspace which runs JupyterLab in a Pod",
  "deprecated": false,
  "deprecation_message": "This WorkspaceKind will be removed on 20XX-XX-XX, please use another WorkspaceKind.",
  "hidden": false,
  "icon <- add": {
    "url": "https://jupyter.org/assets/favicons/apple-touch-icon-152x152.png"
  },
  "logo <- add": {
    "url": "https://upload.wikimedia.org/wikipedia/commons/3/38/Jupyter_logo.svg"
  },
  "pod_template": {
    "pod_metadata": {
      "labels": {
        "my-workspace-kind-label": "my-value"
      },
      "annotations": {
        "my-workspace-kind-annotation": "my-value"
      }
    },
    "volume_mounts <- add": {
      "home": "/home/jovyan"
    },
    "options <- add": {
      "image_config": {
        "default <- add": "jupyterlab_scipy_190",
        "values": [
          {
            "id": "jupyterlab_scipy_180",
            "displayName": "JupyterLab, with SciPy Packages",
            "add labels, hidden redirect (to and message and level), ": "Jupyter"
          },
          {
            ".other image configs..": "..."
          }
        ]
      },

      "pod_config <- add": {
        "default": "tiny_cpu",
        "values": [
          {
            "id": "tiny_cpu",
            "displayName": "Tiny CPU",
            "description": "0.5",
            "add labels fields as key value": "1Gi"
          },
          {
            "i...others": "others"
          }
        ]
      }
    }
  },
  "status <add->": {
    "add status fields": "add status fields"
  }
}
@liavweiss
Copy link

Hey @ederign I want to work with Yehudit https://github.com/yehudit1987 on this issue

@ederign
Copy link
Member Author

ederign commented Nov 26, 2024

/assign @liavweiss

@ederign
Copy link
Member Author

ederign commented Dec 2, 2024

@thesuperzapper, can you please double-check the initial payload for it when you have a chance?

yehudit1987 added a commit to yehudit1987/notebooks that referenced this issue Dec 4, 2024
@ederign ederign moved this from Needs Triage to In Progress in Kubeflow Notebooks Dec 4, 2024
yehudit1987 pushed a commit to yehudit1987/notebooks that referenced this issue Dec 12, 2024
yehudit1987 pushed a commit to yehudit1987/notebooks that referenced this issue Jan 14, 2025
@thesuperzapper
Copy link
Member

Resolved by #192

/close

Copy link

@thesuperzapper: Closing this issue.

In response to this:

Resolved by #192

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Kubeflow Notebooks Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants