update volcano scheduler to 1.8.0; ignore vendor #589
Conversation
lowang-bh
force-pushed
the
volcano-release
branch
from
dcd3410 to
d8a7aa7
Compare
| @@ -6,3 +6,4 @@ profile.cov | |||
| hack/python-sdk/openapi-generator-cli.jar | |||
| dep-crds/ | |||
| dep-manifests/ | |||
| vendor/ | |||
There was a problem hiding this comment.
why is this necessary?
There was a problem hiding this comment.
In case of git add . to include the vendor dir.
There was a problem hiding this comment.
@lowang-bh We don't use vendoring in this repository. So I don't think we need this ignoring. Are there any reasons for this ignore?
There was a problem hiding this comment.
@tenzen-y sometimes user runs go mod vendor. In case of git add . to include it. I can remove it if it is really not need.
There was a problem hiding this comment.
I'm ok with adding vendor to .gitignore.
Signed-off-by: lowang-bh <[email protected]>
lowang-bh
force-pushed
the
volcano-release
branch
from
d8a7aa7 to
d6f6a30
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fix issue #586
To keep update for volcano release 1.8.0