Skip to content
This repository was archived by the owner on Dec 2, 2021. It is now read-only.

[MLMD] Sync up changes from Pipelines to Execution / Artifacts view #217

Closed
3 tasks done
avdaredevil opened this issue Mar 5, 2020 · 3 comments · Fixed by #218
Closed
3 tasks done

[MLMD] Sync up changes from Pipelines to Execution / Artifacts view #217

avdaredevil opened this issue Mar 5, 2020 · 3 comments · Fixed by #218

Comments

@avdaredevil
Copy link
Contributor

avdaredevil commented Mar 5, 2020

About

With MLMD changes complete, and all lineage components in kubeflow/frontend. There are some other components that would make sense to migrate:

  • ArtifactDetails.tsx
  • ExecutionDetails.tsx
  • ExecutionList.tsx

@Bobgy Would there be a way to make sure all future changes are propagated similarly, for the time being. I understand that creating shared versions of these components makes sense in the longer term, but I do not have the cycles to carry forward that change currently.

Current Plan

Manually review the diffs and update the files in this repo, so all the new Lineage Relevant updates are present here as well

Meta

/area metadata
/area front-end
/priority p1
/assign @avdaredevil
/cc @kwasi

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
feature 0.73

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@Bobgy
Copy link
Contributor

Bobgy commented Mar 6, 2020

@avdaredevil Thanks for filing the issue!

I think there's no easier way other than creating shared components.
I can see if I can put these into KFP 1.0 plan if you don't have cycles, but I don't expect any changes in those components for the foreseeable future. Maybe it's not very urgent.

One question what does all the new Lineage Relevant updates mean?

@Bobgy
Copy link
Contributor

Bobgy commented Mar 6, 2020

Actually, I guess the next major features for those pages is: kubeflow/pipelines#3157 and adding server side pagination.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants